Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/admin: implement schedule edit notifications #96

Open
icxes opened this issue Mar 20, 2024 · 3 comments
Open

website/admin: implement schedule edit notifications #96

icxes opened this issue Mar 20, 2024 · 3 comments
Labels
feature-request issue is suggesting a new feature or a change to an existing feature refactor issue is related to refactoring website issue is related to the website and requires backend work

Comments

@icxes
Copy link
Collaborator

icxes commented Mar 20, 2024

For editing the schedule, there should be 2 things

  • a page in /admin where admins can edit the schedule (set/remove/change dj and maybe edit description?) for each day
  • a page where a DJ on the schedule can edit their own description
    • also possibly remove themselves from their own day, or mark themselves as inactive?
    • this could just be their profile page

I had thought we could just use the djtext field from the djs table instead of having a separate column for it in the schedule table, since that would also let people who are currently not on the schedule set a description. We already need the djimage for each user from the djs table anyway.

@icxes icxes added the pre-1.0 issue needs to be resolved before launch label Mar 20, 2024
@icxes icxes changed the title website/admin: editing schedule website/admin: implement editing schedule Apr 29, 2024
@Wessie
Copy link
Contributor

Wessie commented May 13, 2024

/admin/schedule is now implemented, but the way it is implemented should probably be changed such that when setting an owner the user can change the schedule text instead of using dj.text

@Wessie
Copy link
Contributor

Wessie commented May 13, 2024

The current implementation also doesn't let us be aware of when a schedule was updated exactly so we can't do notifications right now

@Wessie Wessie added feature-request issue is suggesting a new feature or a change to an existing feature refactor issue is related to refactoring website issue is related to the website and requires backend work and removed pre-1.0 issue needs to be resolved before launch labels May 13, 2024
@Wessie Wessie changed the title website/admin: implement editing schedule website/admin: implement schedule edit notifications May 15, 2024
@icxes
Copy link
Collaborator Author

icxes commented Dec 25, 2024

/admin/schedule is now implemented, but the way it is implemented should probably be changed such that when setting an owner the user can change the schedule text instead of using dj.text

I like using dj.text (which IIRC is what's set by "DJ text" on the profile page"), since it allows a "placeholder" text for the day if no DJ is set. Associating a DJ's stream description with the user also just makes sense to me in general. It does have the downside of not being able to set 2 different descriptions for 2 different days for the same user, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request issue is suggesting a new feature or a change to an existing feature refactor issue is related to refactoring website issue is related to the website and requires backend work
Projects
None yet
Development

No branches or pull requests

2 participants