Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins load from packages is missing regex check #524

Closed
GeckoEidechse opened this issue Jul 29, 2023 · 0 comments · Fixed by #525
Closed

Plugins load from packages is missing regex check #524

GeckoEidechse opened this issue Jul 29, 2023 · 0 comments · Fixed by #525
Assignees

Comments

@GeckoEidechse
Copy link
Member

Ugh, I just realised another issue with this.

This doesn't do the regex check that the modmanager.cpp code does to ensure that package is installed correctly.

// Set up regex for `AUTHOR-MOD-VERSION` pattern
std::regex pattern(R"(.*\\([a-zA-Z0-9_]+)-([a-zA-Z0-9_]+)-(\d+\.\d+\.\d+))");

Also I'm pretty sure it still loads plugins recursively which we shouldn't need to do anymore. The only reason we added recursive load was to have a plugin -> Thunderstore-package mapping with the old plugin system, i.e. #460 which can also be reverted now.

Originally posted by @GeckoEidechse in #513 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants