Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All gamemodes in private match are marked as locked #878

Closed
GeckoEidechse opened this issue Sep 10, 2024 · 2 comments · Fixed by #880
Closed

All gamemodes in private match are marked as locked #878

GeckoEidechse opened this issue Sep 10, 2024 · 2 comments · Fixed by #880
Labels
bug Something isn't working

Comments

@GeckoEidechse
Copy link
Member

image

Bug introduced in #624 (I failed to catch it in testing cause I was tired, sorry)
@GeckoEidechse GeckoEidechse added the bug Something isn't working label Sep 10, 2024
@Zanieon
Copy link
Contributor

Zanieon commented Sep 11, 2024

It seems like it happens because of this section in menu_mode_select.nut

Disabling it fixes it

You don't even need to disable it, you just need to remove the ! in front of the check of PrivateMatch_IsValidMapModeCombo

@NachosChipeados
Copy link
Contributor

Oh right yeah, i missed that

@Zanieon Zanieon linked a pull request Sep 11, 2024 that will close this issue
Fix mode selection menu locking all modes #880
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mode selection menu locking all modes Zanieon/NorthstarMods
3 participants
@Zanieon @GeckoEidechse @NachosChipeados