Quickfix in wrong attacker receiving progression stat updates #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zanieon
added
the
needs code review
ASpoonPlaysGames
approved these changes
Oct 22, 2023
ASpoonPlaysGames
added
READY TO MERGE
|
I'm not going to enforce testing for this PR, its such a simple change that you can tell that it'll work based on the surrounding logic |
ASpoonPlaysGames
changed the title
GeckoEidechse
changed the title
|
Trusting @ASpoonPlaysGames on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when assisting players with Titan kills the Assist Stat Tracking is still tracking to attacker, this took me a while to notice only because recently I resetted my whole persistent data to ensure everything is tracking properly for progression, and this popped in.