From dc9337ea54dbb0d288b870dcc8b549aef1f4d8df Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 19 Apr 2023 14:25:17 +0200
Subject: [PATCH 01/54] feat: add component skeleton

---
 .../src/components/LaunchArgumentsSelector.vue   | 16 ++++++++++++++++
 src-vue/src/views/SettingsView.vue               | 10 +++++++++-
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 src-vue/src/components/LaunchArgumentsSelector.vue

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
new file mode 100644
index 000000000..9ab599b36
--- /dev/null
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -0,0 +1,16 @@
+<template>
+    <div>
+        Launch arguments selector
+    </div>
+</template>
+
+<script lang="ts">
+import { defineComponent } from 'vue';
+
+export default defineComponent({
+    name: 'LaunchArgumentsSelector',
+    computed: {
+
+    }
+});
+</script>
\ No newline at end of file
diff --git a/src-vue/src/views/SettingsView.vue b/src-vue/src/views/SettingsView.vue
index 772a4c5c5..45636494b 100644
--- a/src-vue/src/views/SettingsView.vue
+++ b/src-vue/src/views/SettingsView.vue
@@ -16,6 +16,12 @@
                     </el-input>
                 </div>
 
+                <!-- Launch arguments selection -->
+                <div class="fc_parameter__panel">
+                    <h3>Launch arguments</h3>
+                    <launch-arguments-selector/>
+                </div>
+
                 <!-- Thunderstore mods per page configuration -->
                 <div class="fc_parameter__panel">
                     <h3>{{ $t('settings.nb_ts_mods_per_page') }}</h3>
@@ -77,12 +83,14 @@ import { ReleaseCanal } from "../utils/ReleaseCanal";
 import { Store } from 'tauri-plugin-store-api';
 import { showErrorNotification, showNotification } from "../utils/ui";
 import LanguageSelector from "../components/LanguageSelector.vue";
+import LaunchArgumentsSelector from "../components/LaunchArgumentsSelector.vue";
 const persistentStore = new Store('flight-core-settings.json');
 
 export default defineComponent({
     name: "SettingsView",
     components: {
-        LanguageSelector
+        LanguageSelector,
+        LaunchArgumentsSelector
     },
     data() {
         return {

From 264356ea48838be547b2b334676c99668d07f731 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 19 Apr 2023 14:36:52 +0200
Subject: [PATCH 02/54] feat: list launch arguments

---
 .../src/components/LaunchArgumentsSelector.vue    | 15 ++++++++++++++-
 src-vue/src/utils/LaunchArgument.ts               |  9 +++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 src-vue/src/utils/LaunchArgument.ts

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 9ab599b36..8bf274da2 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -6,11 +6,24 @@
 
 <script lang="ts">
 import { defineComponent } from 'vue';
+import { LaunchArgument } from '../utils/LaunchArgument';
 
 export default defineComponent({
     name: 'LaunchArgumentsSelector',
     computed: {
-
+        arguments(): LaunchArgument[] {
+            return [
+                new LaunchArgument("-disablelogs", "Disable logging and creation of log files"),
+                new LaunchArgument("-vanilla", "Disables Northstar loading"),
+                new LaunchArgument("-northstar", "Enables Northstar loading"),
+                new LaunchArgument("-dedicated", "Starts a dedicated server without video output"),
+                new LaunchArgument("-waitfordebugger", "Waits for debugger to connect before launching game"),
+                new LaunchArgument("-enablechathooks", "Enables the use of chathooks for use by mods"),
+                new LaunchArgument("-noplugins", "Disables the plugin system"),
+                new LaunchArgument("-novid", "Disables startup videos"),
+                new LaunchArgument("-nosound", "Disables all game sounds")
+            ];
+        }
     }
 });
 </script>
\ No newline at end of file
diff --git a/src-vue/src/utils/LaunchArgument.ts b/src-vue/src/utils/LaunchArgument.ts
new file mode 100644
index 000000000..d6eeeb8ad
--- /dev/null
+++ b/src-vue/src/utils/LaunchArgument.ts
@@ -0,0 +1,9 @@
+export class LaunchArgument {
+    public argumentName: string;
+    public i18nEntry: string;
+
+    constructor(argumentName: string, i18nEntry: string) {
+        this.argumentName = argumentName;
+        this.i18nEntry = i18nEntry;
+    }
+}
\ No newline at end of file

From 3fba9861a376f173eee9aa6b01717450c056613a Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 20 Apr 2023 17:17:02 +0200
Subject: [PATCH 03/54] feat: list launch args as tags

---
 .../src/components/LaunchArgumentsSelector.vue  | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 8bf274da2..8aa226015 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,6 +1,12 @@
 <template>
     <div>
-        Launch arguments selector
+        <el-check-tag 
+            v-for="argument of arguments"
+            checked
+            class="fc-launch_arg_tag"
+        >
+            {{ argument.argumentName }}
+        </el-check-tag>
     </div>
 </template>
 
@@ -26,4 +32,11 @@ export default defineComponent({
         }
     }
 });
-</script>
\ No newline at end of file
+</script>
+
+<style scoped>
+.fc-launch_arg_tag {
+    margin: 0 8px 8px 8px;
+    white-space: nowrap;
+}
+</style>
\ No newline at end of file

From 8a7a82ffb6901a002ff1a7216421c1197f48ded2 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 20 Apr 2023 17:20:47 +0200
Subject: [PATCH 04/54] feat: sort arguments by name

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 8aa226015..88747e14d 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -28,7 +28,7 @@ export default defineComponent({
                 new LaunchArgument("-noplugins", "Disables the plugin system"),
                 new LaunchArgument("-novid", "Disables startup videos"),
                 new LaunchArgument("-nosound", "Disables all game sounds")
-            ];
+            ].sort((a, b) => a.argumentName.localeCompare(b.argumentName));
         }
     }
 });

From 4b047e6c6a20d853f7c769b9dfd09d6dc9ea98e6 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 20 Apr 2023 17:51:02 +0200
Subject: [PATCH 05/54] feat: arguments' description is displayed in tooltips

---
 .../src/components/LaunchArgumentsSelector.vue   | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 88747e14d..d23513a50 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,12 +1,18 @@
 <template>
     <div>
-        <el-check-tag 
+        <el-tooltip
             v-for="argument of arguments"
-            checked
-            class="fc-launch_arg_tag"
+            class="box-item"
+            :content="argument.i18nEntry"
+            placement="bottom"
         >
-            {{ argument.argumentName }}
-        </el-check-tag>
+            <el-check-tag
+                checked
+                class="fc-launch_arg_tag"
+            >
+                {{ argument.argumentName }}
+            </el-check-tag>
+        </el-tooltip>
     </div>
 </template>
 

From 1a0e7fb4dbeadf68bbb59c6278e8b1d9313082fa Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 20 Apr 2023 18:03:57 +0200
Subject: [PATCH 06/54] feat: translate tags container to align tags with other
 interface components

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index d23513a50..1bd980946 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,5 +1,5 @@
 <template>
-    <div>
+    <div class="fc-tags_container">
         <el-tooltip
             v-for="argument of arguments"
             class="box-item"
@@ -45,4 +45,8 @@ export default defineComponent({
     margin: 0 8px 8px 8px;
     white-space: nowrap;
 }
+
+.fc-tags_container {
+    transform: translateX(-8px);
+}
 </style>
\ No newline at end of file

From 7340a90571fc1a7eedc6bdb4a28d5b56fe2f9c17 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 20 Apr 2023 18:36:31 +0200
Subject: [PATCH 07/54] feat: tags are unclickable if no game path is selected

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 1bd980946..2f976b3f5 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,5 +1,5 @@
 <template>
-    <div class="fc-tags_container">
+    <div :class="containerClasses">
         <el-tooltip
             v-for="argument of arguments"
             class="box-item"
@@ -19,6 +19,7 @@
 <script lang="ts">
 import { defineComponent } from 'vue';
 import { LaunchArgument } from '../utils/LaunchArgument';
+import { NorthstarState } from '../utils/NorthstarState';
 
 export default defineComponent({
     name: 'LaunchArgumentsSelector',
@@ -35,6 +36,12 @@ export default defineComponent({
                 new LaunchArgument("-novid", "Disables startup videos"),
                 new LaunchArgument("-nosound", "Disables all game sounds")
             ].sort((a, b) => a.argumentName.localeCompare(b.argumentName));
+        },
+        containerClasses(): string {
+            return this.gamePathIsSelected ? 'fc-tags_container' : 'fc-tags_container disabled_container';
+        },
+        gamePathIsSelected(): boolean {
+            return this.$store.state.northstar_state !== NorthstarState.GAME_NOT_FOUND;
         }
     }
 });
@@ -49,4 +56,9 @@ export default defineComponent({
 .fc-tags_container {
     transform: translateX(-8px);
 }
+
+.disabled_container {
+    pointer-events: none;
+    filter: grayscale();
+}
 </style>
\ No newline at end of file

From dfed835bca000d854dda9a1a23dbde07afb6bfc7 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 20 Apr 2023 18:55:17 +0200
Subject: [PATCH 08/54] feat: store arguments activation state in component
 state

---
 .../src/components/LaunchArgumentsSelector.vue   | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 2f976b3f5..e050f54e2 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,14 +1,15 @@
 <template>
     <div :class="containerClasses">
         <el-tooltip
-            v-for="argument of arguments"
+            v-for="(argument, index) in arguments"
             class="box-item"
             :content="argument.i18nEntry"
             placement="bottom"
         >
             <el-check-tag
-                checked
                 class="fc-launch_arg_tag"
+                :checked="values[index]"
+                @change="onChange(index)"
             >
                 {{ argument.argumentName }}
             </el-check-tag>
@@ -43,6 +44,17 @@ export default defineComponent({
         gamePathIsSelected(): boolean {
             return this.$store.state.northstar_state !== NorthstarState.GAME_NOT_FOUND;
         }
+    },
+    data: () => ({
+        values: [] as boolean[]
+    }),
+    methods: {
+        onChange(index: number) {
+            this.values[index] = !this.values[index];
+        }
+    },
+    mounted() {
+        this.values = this.arguments.map(a => false);
     }
 });
 </script>

From bb38eaf63b6891d047455f01fa63a9039bcde60c Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sat, 22 Apr 2023 16:56:19 +0200
Subject: [PATCH 09/54] feat: backend get_launch_arguments method reads
 arguments from file

---
 src-tauri/src/main.rs                       |  3 ++-
 src-tauri/src/northstar/launch_arguments.rs | 15 +++++++++++++++
 src-tauri/src/northstar/mod.rs              |  1 +
 3 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 src-tauri/src/northstar/launch_arguments.rs

diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs
index 3aa174599..af00a9801 100644
--- a/src-tauri/src/main.rs
+++ b/src-tauri/src/main.rs
@@ -115,6 +115,7 @@ fn main() {
             find_game_install_location_caller,
             get_flightcore_version_number,
             get_northstar_version_number_caller,
+            northstar::launch_arguments::get_launch_arguments,
             check_is_northstar_outdated,
             verify_install_location,
             get_host_os_caller,
@@ -145,7 +146,7 @@ fn main() {
             apply_launcher_pr,
             apply_mods_pr,
             get_launcher_download_link,
-            close_application,
+            close_application
         ])
         .run(tauri::generate_context!())
         .expect("error while running tauri application");
diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
new file mode 100644
index 000000000..97f20b30e
--- /dev/null
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -0,0 +1,15 @@
+#[tauri::command]
+pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
+    // If file does not exist, we return an empty list
+    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
+    if !std::path::Path::new(&launch_args_path).exists() {
+        return Ok(vec![]);
+    }
+
+    let data =  match std::fs::read_to_string(launch_args_path.clone()) {
+        Ok(content) => content,
+        Err(_) => { return Ok(vec![]); }
+    };
+
+    Ok(data.split_whitespace().map(|arg| arg.to_string()).collect())
+}
diff --git a/src-tauri/src/northstar/mod.rs b/src-tauri/src/northstar/mod.rs
index 7bd0b0a3b..b5fd3cb79 100644
--- a/src-tauri/src/northstar/mod.rs
+++ b/src-tauri/src/northstar/mod.rs
@@ -3,6 +3,7 @@
 
 use crate::{check_mod_version_number, constants::CORE_MODS};
 use anyhow::anyhow;
+pub mod launch_arguments;
 
 /// Returns the current Northstar version number as a string
 pub fn get_northstar_version_number(game_path: &str) -> Result<String, anyhow::Error> {

From d2c96a99bd91e782b3f1bc8b1cb125944e5bbec5 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sat, 22 Apr 2023 17:17:50 +0200
Subject: [PATCH 10/54] feat: highlight arguments present in args file

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index e050f54e2..67f267fea 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -21,6 +21,7 @@
 import { defineComponent } from 'vue';
 import { LaunchArgument } from '../utils/LaunchArgument';
 import { NorthstarState } from '../utils/NorthstarState';
+import {invoke} from "@tauri-apps/api";
 
 export default defineComponent({
     name: 'LaunchArgumentsSelector',
@@ -53,8 +54,15 @@ export default defineComponent({
             this.values[index] = !this.values[index];
         }
     },
-    mounted() {
+    async mounted() {
         this.values = this.arguments.map(a => false);
+
+        const fileArgs = await invoke<string[]>("get_launch_arguments", { gamePath: this.$store.state.game_path});
+        this.arguments.forEach((argument, index) => {
+            if (fileArgs.includes(argument.argumentName)) {
+                this.values[index] = true;
+            }
+        });
     }
 });
 </script>
@@ -73,4 +81,4 @@ export default defineComponent({
     pointer-events: none;
     filter: grayscale();
 }
-</style>
\ No newline at end of file
+</style>

From 4cfdbfb5abc79b82c76b014c5d64055eb4ebd922 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 30 Apr 2023 23:39:39 +0200
Subject: [PATCH 11/54] feat: add set_launch_arguments Rust method to update
 launch args file

---
 src-tauri/src/main.rs                       |  1 +
 src-tauri/src/northstar/launch_arguments.rs | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs
index af00a9801..580a17873 100644
--- a/src-tauri/src/main.rs
+++ b/src-tauri/src/main.rs
@@ -116,6 +116,7 @@ fn main() {
             get_flightcore_version_number,
             get_northstar_version_number_caller,
             northstar::launch_arguments::get_launch_arguments,
+            northstar::launch_arguments::set_launch_arguments,
             check_is_northstar_outdated,
             verify_install_location,
             get_host_os_caller,
diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 97f20b30e..0481ee392 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -13,3 +13,20 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 
     Ok(data.split_whitespace().map(|arg| arg.to_string()).collect())
 }
+
+#[tauri::command]
+pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
+    // If file does not exist, we return an empty list
+    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
+    if !std::path::Path::new(&launch_args_path).exists() {
+        return Err("Launch arguments file does not exist.".to_string());
+    }
+
+    match std::fs::write(launch_args_path.clone(), arguments.join(" ")) {
+        Ok(..) => (),
+        Err(_) => return Err("Failed to save launch arguments.".to_string()),
+    }
+
+    log::info!("Launch arguments updated.");
+    Ok(())
+}

From 1ac3360814de8ad241f856f255fdb263631cea79 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 30 Apr 2023 23:40:21 +0200
Subject: [PATCH 12/54] feat: update launch args file on argument (de)selection

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 67f267fea..d3a9e2257 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -52,6 +52,16 @@ export default defineComponent({
     methods: {
         onChange(index: number) {
             this.values[index] = !this.values[index];
+
+            const newArgs = this.arguments
+                .filter((value: LaunchArgument, index: number) => {
+                    return this.values[index];
+                })
+                .map((value: LaunchArgument) => value.argumentName)
+
+            invoke<string[]>("set_launch_arguments", {
+                gamePath: this.$store.state.game_path, arguments: newArgs
+            });
         }
     },
     async mounted() {

From 73ab8a90d93fbf0ad4e96ad7fd86e63dccbd8bec Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 2 May 2023 08:24:45 +0200
Subject: [PATCH 13/54] feat: display custom arguments

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index d3a9e2257..b05136b2c 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -27,7 +27,7 @@ export default defineComponent({
     name: 'LaunchArgumentsSelector',
     computed: {
         arguments(): LaunchArgument[] {
-            return [
+            const officialArguments = [
                 new LaunchArgument("-disablelogs", "Disable logging and creation of log files"),
                 new LaunchArgument("-vanilla", "Disables Northstar loading"),
                 new LaunchArgument("-northstar", "Enables Northstar loading"),
@@ -37,7 +37,10 @@ export default defineComponent({
                 new LaunchArgument("-noplugins", "Disables the plugin system"),
                 new LaunchArgument("-novid", "Disables startup videos"),
                 new LaunchArgument("-nosound", "Disables all game sounds")
-            ].sort((a, b) => a.argumentName.localeCompare(b.argumentName));
+            ];
+
+            return (this.localCustomArgs.concat(officialArguments))
+                .sort((a, b) => a.argumentName.localeCompare(b.argumentName));
         },
         containerClasses(): string {
             return this.gamePathIsSelected ? 'fc-tags_container' : 'fc-tags_container disabled_container';
@@ -47,7 +50,8 @@ export default defineComponent({
         }
     },
     data: () => ({
-        values: [] as boolean[]
+        values: [] as boolean[],
+        localCustomArgs: [] as LaunchArgument[]
     }),
     methods: {
         onChange(index: number) {
@@ -68,6 +72,8 @@ export default defineComponent({
         this.values = this.arguments.map(a => false);
 
         const fileArgs = await invoke<string[]>("get_launch_arguments", { gamePath: this.$store.state.game_path});
+        this.localCustomArgs = fileArgs.map(arg => new LaunchArgument(arg, ''));
+        
         this.arguments.forEach((argument, index) => {
             if (fileArgs.includes(argument.argumentName)) {
                 this.values[index] = true;

From da58e2ee26eadfc22fd0872a9104cea6e27883c1 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 2 May 2023 08:29:59 +0200
Subject: [PATCH 14/54] fix: do not display tooltip for custom arguments

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index b05136b2c..e64ec2fb6 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -5,6 +5,7 @@
             class="box-item"
             :content="argument.i18nEntry"
             placement="bottom"
+            :disabled="argument.i18nEntry.length === 0"
         >
             <el-check-tag
                 class="fc-launch_arg_tag"
@@ -73,7 +74,7 @@ export default defineComponent({
 
         const fileArgs = await invoke<string[]>("get_launch_arguments", { gamePath: this.$store.state.game_path});
         this.localCustomArgs = fileArgs.map(arg => new LaunchArgument(arg, ''));
-        
+
         this.arguments.forEach((argument, index) => {
             if (fileArgs.includes(argument.argumentName)) {
                 this.values[index] = true;

From e4a81cb6d952bbd5def3137fc51d850940694407 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 2 May 2023 18:58:00 +0200
Subject: [PATCH 15/54] feat: add button to add new tags

---
 .../components/LaunchArgumentsSelector.vue    | 40 ++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index e64ec2fb6..be51b2a12 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -15,6 +15,20 @@
                 {{ argument.argumentName }}
             </el-check-tag>
         </el-tooltip>
+
+        <!-- User-input tag -->
+        <el-input
+            v-if="inputVisible"
+            ref="InputRef"
+            class="fc-tag__input"
+            v-model="inputValue"
+            size="small"
+            @keyup.enter="handleInputConfirm"
+            @blur="handleInputConfirm"
+        />
+        <el-button v-else class="button-new-tag ml-1" size="small" @click="showInput">
+            + New launch argument
+        </el-button>
     </div>
 </template>
 
@@ -51,6 +65,9 @@ export default defineComponent({
         }
     },
     data: () => ({
+        inputValue: '',
+        inputVisible: false,
+
         values: [] as boolean[],
         localCustomArgs: [] as LaunchArgument[]
     }),
@@ -67,7 +84,24 @@ export default defineComponent({
             invoke<string[]>("set_launch_arguments", {
                 gamePath: this.$store.state.game_path, arguments: newArgs
             });
-        }
+        },
+        showInput() {
+            this.inputVisible = true;
+            this.$nextTick(() => {
+                // @ts-ignore
+                this.$refs.InputRef.input.focus();
+            });
+        },
+        handleInputConfirm() {
+            if (this.inputValue.length !== 0) {
+                const newArgument: LaunchArgument = new LaunchArgument(this.inputValue, '');
+                this.localCustomArgs.push( newArgument );
+                const index: number = this.arguments.map(arg => arg.argumentName).indexOf(newArgument.argumentName);
+                this.values.splice(index, 0, true);
+            }
+            this.inputVisible = false;
+            this.inputValue = '';
+        },
     },
     async mounted() {
         this.values = this.arguments.map(a => false);
@@ -98,4 +132,8 @@ export default defineComponent({
     pointer-events: none;
     filter: grayscale();
 }
+
+.fc-tag__input {
+    width: auto;
+}
 </style>

From f817509b1e6c6257625eb23dc42a2f9a9bcea61a Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 2 May 2023 19:11:27 +0200
Subject: [PATCH 16/54] feat: save arguments when inputting a new one

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index be51b2a12..8ffe59724 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -74,7 +74,9 @@ export default defineComponent({
     methods: {
         onChange(index: number) {
             this.values[index] = !this.values[index];
-
+            this.saveLaunchArgumentsToFile();
+        },
+        saveLaunchArgumentsToFile() {
             const newArgs = this.arguments
                 .filter((value: LaunchArgument, index: number) => {
                     return this.values[index];
@@ -98,6 +100,7 @@ export default defineComponent({
                 this.localCustomArgs.push( newArgument );
                 const index: number = this.arguments.map(arg => arg.argumentName).indexOf(newArgument.argumentName);
                 this.values.splice(index, 0, true);
+                this.saveLaunchArgumentsToFile();
             }
             this.inputVisible = false;
             this.inputValue = '';

From bc236d017f2ba48824f52b531eb8df9c23ae50e2 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 2 May 2023 23:52:52 +0200
Subject: [PATCH 17/54] feat: LaunchArgument.i18nEntry is an empty string by
 default

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 4 ++--
 src-vue/src/utils/LaunchArgument.ts                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 8ffe59724..83785bb92 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -96,7 +96,7 @@ export default defineComponent({
         },
         handleInputConfirm() {
             if (this.inputValue.length !== 0) {
-                const newArgument: LaunchArgument = new LaunchArgument(this.inputValue, '');
+                const newArgument: LaunchArgument = new LaunchArgument(this.inputValue);
                 this.localCustomArgs.push( newArgument );
                 const index: number = this.arguments.map(arg => arg.argumentName).indexOf(newArgument.argumentName);
                 this.values.splice(index, 0, true);
@@ -110,7 +110,7 @@ export default defineComponent({
         this.values = this.arguments.map(a => false);
 
         const fileArgs = await invoke<string[]>("get_launch_arguments", { gamePath: this.$store.state.game_path});
-        this.localCustomArgs = fileArgs.map(arg => new LaunchArgument(arg, ''));
+        this.localCustomArgs = fileArgs.map(arg => new LaunchArgument(arg));
 
         this.arguments.forEach((argument, index) => {
             if (fileArgs.includes(argument.argumentName)) {
diff --git a/src-vue/src/utils/LaunchArgument.ts b/src-vue/src/utils/LaunchArgument.ts
index d6eeeb8ad..55b907bd4 100644
--- a/src-vue/src/utils/LaunchArgument.ts
+++ b/src-vue/src/utils/LaunchArgument.ts
@@ -2,7 +2,7 @@ export class LaunchArgument {
     public argumentName: string;
     public i18nEntry: string;
 
-    constructor(argumentName: string, i18nEntry: string) {
+    constructor(argumentName: string, i18nEntry: string = '') {
         this.argumentName = argumentName;
         this.i18nEntry = i18nEntry;
     }

From c5d43508cdd31cda2f46129587f758d32131a001 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 3 May 2023 00:06:27 +0200
Subject: [PATCH 18/54] feat: prevent adding the same argument multiple times

---
 .../src/components/LaunchArgumentsSelector.vue    | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 83785bb92..6b25aed29 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -96,11 +96,16 @@ export default defineComponent({
         },
         handleInputConfirm() {
             if (this.inputValue.length !== 0) {
-                const newArgument: LaunchArgument = new LaunchArgument(this.inputValue);
-                this.localCustomArgs.push( newArgument );
-                const index: number = this.arguments.map(arg => arg.argumentName).indexOf(newArgument.argumentName);
-                this.values.splice(index, 0, true);
-                this.saveLaunchArgumentsToFile();
+                const allArgumentsNames: string[] = this.arguments.map(arg => arg.argumentName);
+                if (allArgumentsNames.indexOf(this.inputValue) !== -1) {
+                    console.warn(`Argument "${this.inputValue}" already present, ignoring.`);
+                } else {
+                    const newArgument: LaunchArgument = new LaunchArgument(this.inputValue);
+                    this.localCustomArgs.push( newArgument );
+                    const index: number = allArgumentsNames.indexOf(newArgument.argumentName);
+                    this.values.splice(index, 0, true);
+                    this.saveLaunchArgumentsToFile();
+                }
             }
             this.inputVisible = false;
             this.inputValue = '';

From 103c7593ff6b0c4b0df4d2603116ffed9241c12b Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 3 May 2023 00:11:58 +0200
Subject: [PATCH 19/54] style: format launch_arguments.rs file

---
 src-tauri/src/northstar/launch_arguments.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 0481ee392..ae0b1cccf 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -6,9 +6,11 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
         return Ok(vec![]);
     }
 
-    let data =  match std::fs::read_to_string(launch_args_path.clone()) {
+    let data = match std::fs::read_to_string(launch_args_path.clone()) {
         Ok(content) => content,
-        Err(_) => { return Ok(vec![]); }
+        Err(_) => {
+            return Ok(vec![]);
+        }
     };
 
     Ok(data.split_whitespace().map(|arg| arg.to_string()).collect())

From 25d32c0fe1f05ec3766bf4c433efa56d8b04488d Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 3 May 2023 19:00:35 +0200
Subject: [PATCH 20/54] fix: don't throw if ns_startup_args.txt file does not
 exist

---
 src-tauri/src/northstar/launch_arguments.rs | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index ae0b1cccf..2cd1d018b 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -18,12 +18,8 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 
 #[tauri::command]
 pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
-    // If file does not exist, we return an empty list
     let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
-    if !std::path::Path::new(&launch_args_path).exists() {
-        return Err("Launch arguments file does not exist.".to_string());
-    }
-
+    
     match std::fs::write(launch_args_path.clone(), arguments.join(" ")) {
         Ok(..) => (),
         Err(_) => return Err("Failed to save launch arguments.".to_string()),

From 147ecd5e6aaa2238d8cf21e129a590da4953cc31 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 3 May 2023 19:11:43 +0200
Subject: [PATCH 21/54] docs: add documentation to Rust methods

---
 src-tauri/src/northstar/launch_arguments.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 2cd1d018b..a97d53eb2 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -1,6 +1,8 @@
 #[tauri::command]
+/// This method loads arguments from the ns_startup_args.txt Northstar launch
+/// arguments files.
+/// If this file does not exist, this will return an empty array.
 pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
-    // If file does not exist, we return an empty list
     let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
     if !std::path::Path::new(&launch_args_path).exists() {
         return Ok(vec![]);
@@ -17,6 +19,9 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 }
 
 #[tauri::command]
+/// This method puts an array of arguments into the ns_startup_args.txt Northstar
+/// launch arguments files.
+/// If the ns_startup_args.txt file does not exist, this will create it.
 pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
     let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
     

From 81cbd6dc832b322e6683172bd4558babd16fe1fd Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 3 May 2023 19:20:31 +0200
Subject: [PATCH 22/54] fix: do not list official arguments twice if they're in
 local arguments file

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 6b25aed29..cce1ec58f 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -42,7 +42,11 @@ export default defineComponent({
     name: 'LaunchArgumentsSelector',
     computed: {
         arguments(): LaunchArgument[] {
-            const officialArguments = [
+            return (this.localCustomArgs.concat(this.officialArguments))
+                .sort((a, b) => a.argumentName.localeCompare(b.argumentName));
+        },
+        officialArguments(): LaunchArgument[] {
+            return [
                 new LaunchArgument("-disablelogs", "Disable logging and creation of log files"),
                 new LaunchArgument("-vanilla", "Disables Northstar loading"),
                 new LaunchArgument("-northstar", "Enables Northstar loading"),
@@ -53,9 +57,6 @@ export default defineComponent({
                 new LaunchArgument("-novid", "Disables startup videos"),
                 new LaunchArgument("-nosound", "Disables all game sounds")
             ];
-
-            return (this.localCustomArgs.concat(officialArguments))
-                .sort((a, b) => a.argumentName.localeCompare(b.argumentName));
         },
         containerClasses(): string {
             return this.gamePathIsSelected ? 'fc-tags_container' : 'fc-tags_container disabled_container';
@@ -114,8 +115,11 @@ export default defineComponent({
     async mounted() {
         this.values = this.arguments.map(a => false);
 
+        // Only add to local arguments those who are not in official arguments array
         const fileArgs = await invoke<string[]>("get_launch_arguments", { gamePath: this.$store.state.game_path});
-        this.localCustomArgs = fileArgs.map(arg => new LaunchArgument(arg));
+        this.localCustomArgs = fileArgs
+            .filter(arg => this.officialArguments.map(oArg => oArg.argumentName).indexOf(arg) === -1)
+            .map(arg => new LaunchArgument(arg));
 
         this.arguments.forEach((argument, index) => {
             if (fileArgs.includes(argument.argumentName)) {

From b72a996f04964349d8dbedebcd97e77bd10662ae Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Fri, 5 May 2023 08:26:50 +0200
Subject: [PATCH 23/54] feat: filter out argument duplicates

---
 src-tauri/src/northstar/launch_arguments.rs | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index a97d53eb2..9ff5e99d7 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -1,6 +1,6 @@
 #[tauri::command]
 /// This method loads arguments from the ns_startup_args.txt Northstar launch
-/// arguments files.
+/// arguments files, filtering out eventual argument duplicates.
 /// If this file does not exist, this will return an empty array.
 pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
     let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
@@ -15,7 +15,12 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
         }
     };
 
-    Ok(data.split_whitespace().map(|arg| arg.to_string()).collect())
+    let mut arguments = data.split_whitespace()
+        .map(|arg| arg.to_string())
+        .collect::<Vec<_>>();
+    arguments.sort_unstable();
+    arguments.dedup();
+    Ok(arguments)
 }
 
 #[tauri::command]

From 0afed6504863a60fab43dd41f442854c6874ca32 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Fri, 5 May 2023 09:18:06 +0200
Subject: [PATCH 24/54] feat: localize user interface

---
 .../components/LaunchArgumentsSelector.vue    | 22 +++++++++----------
 src-vue/src/i18n/lang/en.json                 | 16 ++++++++++++++
 src-vue/src/i18n/lang/fr.json                 | 16 ++++++++++++++
 src-vue/src/views/SettingsView.vue            |  2 +-
 4 files changed, 44 insertions(+), 12 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index cce1ec58f..0a674c8d6 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -3,7 +3,7 @@
         <el-tooltip
             v-for="(argument, index) in arguments"
             class="box-item"
-            :content="argument.i18nEntry"
+            :content="$t(argument.i18nEntry)"
             placement="bottom"
             :disabled="argument.i18nEntry.length === 0"
         >
@@ -27,7 +27,7 @@
             @blur="handleInputConfirm"
         />
         <el-button v-else class="button-new-tag ml-1" size="small" @click="showInput">
-            + New launch argument
+            {{ $t('settings.launch_args.new_arg_btn') }}
         </el-button>
     </div>
 </template>
@@ -47,15 +47,15 @@ export default defineComponent({
         },
         officialArguments(): LaunchArgument[] {
             return [
-                new LaunchArgument("-disablelogs", "Disable logging and creation of log files"),
-                new LaunchArgument("-vanilla", "Disables Northstar loading"),
-                new LaunchArgument("-northstar", "Enables Northstar loading"),
-                new LaunchArgument("-dedicated", "Starts a dedicated server without video output"),
-                new LaunchArgument("-waitfordebugger", "Waits for debugger to connect before launching game"),
-                new LaunchArgument("-enablechathooks", "Enables the use of chathooks for use by mods"),
-                new LaunchArgument("-noplugins", "Disables the plugin system"),
-                new LaunchArgument("-novid", "Disables startup videos"),
-                new LaunchArgument("-nosound", "Disables all game sounds")
+                new LaunchArgument("-disablelogs", "settings.launch_args.descriptions.disablelogs"),
+                new LaunchArgument("-vanilla", "settings.launch_args.descriptions.vanilla"),
+                new LaunchArgument("-northstar", "settings.launch_args.descriptions.northstar"),
+                new LaunchArgument("-dedicated", "settings.launch_args.descriptions.dedicated"),
+                new LaunchArgument("-waitfordebugger", "settings.launch_args.descriptions.waitfordebugger"),
+                new LaunchArgument("-enablechathooks", "settings.launch_args.descriptions.enablechathooks"),
+                new LaunchArgument("-noplugins", "settings.launch_args.descriptions.noplugins"),
+                new LaunchArgument("-novid", "settings.launch_args.descriptions.novid"),
+                new LaunchArgument("-nosound", "settings.launch_args.descriptions.nosound")
             ];
         },
         containerClasses(): string {
diff --git a/src-vue/src/i18n/lang/en.json b/src-vue/src/i18n/lang/en.json
index 407b69d1b..99a86b5b2 100644
--- a/src-vue/src/i18n/lang/en.json
+++ b/src-vue/src/i18n/lang/en.json
@@ -122,6 +122,22 @@
                 "reinstall_text": "Please wait",
                 "reinstall_success": "Successfully reinstalled Northstar"
             }
+        },
+
+        "launch_args": {
+            "title": "Launch arguments",
+            "new_arg_btn": "+ New launch argument",
+            "descriptions": {
+                "disablelogs": "Disable logging and creation of log files",
+                "vanilla": "Disables Northstar loading",
+                "northstar": "Enables Northstar loading",
+                "dedicated": "Starts a dedicated server without video output",
+                "waitfordebugger": "Waits for debugger to connect before launching game",
+                "enablechathooks": "Enables the use of chathooks for use by mods",
+                "noplugins": "Disables the plugin system",
+                "novid": "Disables startup videos",
+                "nosound": "Disables all game sounds"
+            }
         }
     },
 
diff --git a/src-vue/src/i18n/lang/fr.json b/src-vue/src/i18n/lang/fr.json
index aae11bb7f..5ee3d6069 100644
--- a/src-vue/src/i18n/lang/fr.json
+++ b/src-vue/src/i18n/lang/fr.json
@@ -122,6 +122,22 @@
                 "reinstall_text": "Veuillez patienter",
                 "reinstall_success": "Northstar réinstallé avec succès"
             }
+        },
+
+        "launch_args": {
+            "title": "Paramètres de démarrage",
+            "new_arg_btn": "+ Nouveau paramètre",
+            "descriptions": {
+                "disablelogs": "Désactive la journalisation et la création de journaux",
+                "vanilla": "Désactive le chargement de Northstar",
+                "northstar": "Active le chargement de Northstar",
+                "dedicated": "Démarre un serveur dédié sans sortie graphique",
+                "waitfordebugger": "Attend la connexion au débuggueur avant de lancer le jeu",
+                "enablechathooks": "Active les chathooks pour les mods",
+                "noplugins": "Désactive le système de plugins",
+                "novid": "Désactive les vidéos au démarrage",
+                "nosound": "Désactive tous les sons du jeu"
+            }
         }
     },
 
diff --git a/src-vue/src/views/SettingsView.vue b/src-vue/src/views/SettingsView.vue
index 45636494b..097b2bf19 100644
--- a/src-vue/src/views/SettingsView.vue
+++ b/src-vue/src/views/SettingsView.vue
@@ -18,7 +18,7 @@
 
                 <!-- Launch arguments selection -->
                 <div class="fc_parameter__panel">
-                    <h3>Launch arguments</h3>
+                    <h3>{{ $t('settings.launch_args.title') }}</h3>
                     <launch-arguments-selector/>
                 </div>
 

From a17a3ec0b96f02fe243a0ba38894e770efa356f7 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Fri, 5 May 2023 09:27:02 +0200
Subject: [PATCH 25/54] fix: display an error if arguments saving fails

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 0a674c8d6..8beba8158 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -37,6 +37,7 @@ import { defineComponent } from 'vue';
 import { LaunchArgument } from '../utils/LaunchArgument';
 import { NorthstarState } from '../utils/NorthstarState';
 import {invoke} from "@tauri-apps/api";
+import { showErrorNotification } from '../utils/ui';
 
 export default defineComponent({
     name: 'LaunchArgumentsSelector',
@@ -86,6 +87,8 @@ export default defineComponent({
 
             invoke<string[]>("set_launch_arguments", {
                 gamePath: this.$store.state.game_path, arguments: newArgs
+            }).catch((err: any) => {
+                showErrorNotification(err);
             });
         },
         showInput() {

From 51ee713accb1784ced10204e85460876c20be93a Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Fri, 5 May 2023 11:47:36 +0200
Subject: [PATCH 26/54] feat: add a selector component to input language launch
 argument

---
 .../components/LaunchArgumentsSelector.vue    | 43 ++++++++++++++-----
 1 file changed, 33 insertions(+), 10 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 8beba8158..619a2918c 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -16,6 +16,16 @@
             </el-check-tag>
         </el-tooltip>
 
+        <!-- Language selector -->
+        <el-select v-model="langArgumentValue" class="m-2" placeholder="-lang=" @change="onLanguageSelection">
+            <el-option
+                v-for="item in langArgumentOptions"
+                :key="item.value"
+                :label="item.label"
+                :value="item.value"
+            />
+        </el-select>
+
         <!-- User-input tag -->
         <el-input
             v-if="inputVisible"
@@ -64,16 +74,38 @@ export default defineComponent({
         },
         gamePathIsSelected(): boolean {
             return this.$store.state.northstar_state !== NorthstarState.GAME_NOT_FOUND;
+        },
+        langArgumentOptions() {
+            const languages = ['english', 'french', 'german', 'italian', 'japanese', 'mspanish', 'portuguese', 'russian', 'spanish', 'tchinese'];
+            return languages.map(lang => ({value: lang, label: lang}));
         }
     },
     data: () => ({
         inputValue: '',
         inputVisible: false,
 
+        langArgumentValue: '',
         values: [] as boolean[],
         localCustomArgs: [] as LaunchArgument[]
     }),
     methods: {
+        onLanguageSelection( lang: string ) {
+            this.createNewArgument( `-language="${lang}"` );
+        },
+        createNewArgument(arg: string) {
+            let allArgumentsNames: string[] = this.arguments.map(arg => arg.argumentName);
+            if (allArgumentsNames.indexOf(arg) !== -1) {
+                console.warn(`Argument "${arg}" already present, ignoring.`);
+            } else {
+                const newArgument: LaunchArgument = new LaunchArgument(arg);
+                this.localCustomArgs.push( newArgument );
+                allArgumentsNames = this.arguments.map(arg => arg.argumentName);
+
+                const index: number = allArgumentsNames.indexOf(newArgument.argumentName);
+                this.values.splice(index, 0, true);
+                this.saveLaunchArgumentsToFile();
+            }
+        },
         onChange(index: number) {
             this.values[index] = !this.values[index];
             this.saveLaunchArgumentsToFile();
@@ -100,16 +132,7 @@ export default defineComponent({
         },
         handleInputConfirm() {
             if (this.inputValue.length !== 0) {
-                const allArgumentsNames: string[] = this.arguments.map(arg => arg.argumentName);
-                if (allArgumentsNames.indexOf(this.inputValue) !== -1) {
-                    console.warn(`Argument "${this.inputValue}" already present, ignoring.`);
-                } else {
-                    const newArgument: LaunchArgument = new LaunchArgument(this.inputValue);
-                    this.localCustomArgs.push( newArgument );
-                    const index: number = allArgumentsNames.indexOf(newArgument.argumentName);
-                    this.values.splice(index, 0, true);
-                    this.saveLaunchArgumentsToFile();
-                }
+                this.createNewArgument(this.inputValue);
             }
             this.inputVisible = false;
             this.inputValue = '';

From e33ad0a2f0b2bc526815c81f2e9d1ae49b545a01 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Fri, 5 May 2023 11:52:49 +0200
Subject: [PATCH 27/54] feat: display language selector only if there's no
 language argument

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 619a2918c..5ad5840ce 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -17,7 +17,7 @@
         </el-tooltip>
 
         <!-- Language selector -->
-        <el-select v-model="langArgumentValue" class="m-2" placeholder="-lang=" @change="onLanguageSelection">
+        <el-select v-if="displayLanguageSelector" v-model="langArgumentValue" class="m-2" placeholder="-lang=" @change="onLanguageSelection">
             <el-option
                 v-for="item in langArgumentOptions"
                 :key="item.value"
@@ -56,6 +56,13 @@ export default defineComponent({
             return (this.localCustomArgs.concat(this.officialArguments))
                 .sort((a, b) => a.argumentName.localeCompare(b.argumentName));
         },
+        displayLanguageSelector(): boolean {
+            const langArgPrefix = '-language="';
+            return this.arguments
+                .map(arg => arg.argumentName)
+                .filter(name => name.substring(0, langArgPrefix.length) === langArgPrefix)
+                .length === 0;
+        },
         officialArguments(): LaunchArgument[] {
             return [
                 new LaunchArgument("-disablelogs", "settings.launch_args.descriptions.disablelogs"),

From fe647e7aa94932acfae530cbce4d8cc854a2eb55 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Mon, 8 May 2023 17:29:10 +0200
Subject: [PATCH 28/54] refactor: display custom arguments with simple tags

---
 .../components/LaunchArgumentsSelector.vue    | 38 +++++++++++--------
 1 file changed, 23 insertions(+), 15 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 5ad5840ce..722c39705 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,20 +1,27 @@
 <template>
     <div :class="containerClasses">
-        <el-tooltip
-            v-for="(argument, index) in arguments"
-            class="box-item"
-            :content="$t(argument.i18nEntry)"
-            placement="bottom"
-            :disabled="argument.i18nEntry.length === 0"
-        >
-            <el-check-tag
-                class="fc-launch_arg_tag"
-                :checked="values[index]"
-                @change="onChange(index)"
+        <div class="fc-launch_arg_tag_container" 
+                v-for="(argument, index) in arguments">
+            <!-- Official arguments -->
+            <el-tooltip
+                v-if="argument.i18nEntry.length !== 0"
+                class="box-item"
+                :content="$t(argument.i18nEntry)"
+                placement="bottom"
             >
+                <el-check-tag
+                    :checked="values[index]"
+                    @change="onChange(index)"
+                >
+                    {{ argument.argumentName }}
+                </el-check-tag>
+            </el-tooltip>
+
+            <!-- Custom arguments -->
+            <el-tag v-else>
                 {{ argument.argumentName }}
-            </el-check-tag>
-        </el-tooltip>
+            </el-tag>
+        </div>
 
         <!-- Language selector -->
         <el-select v-if="displayLanguageSelector" v-model="langArgumentValue" class="m-2" placeholder="-lang=" @change="onLanguageSelection">
@@ -164,9 +171,10 @@ export default defineComponent({
 </script>
 
 <style scoped>
-.fc-launch_arg_tag {
+
+.fc-launch_arg_tag_container {
+    display: inline-block;
     margin: 0 8px 8px 8px;
-    white-space: nowrap;
 }
 
 .fc-tags_container {

From 33bfb85e8736d12c02b18433f66f322b417cd8a0 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Mon, 8 May 2023 17:50:46 +0200
Subject: [PATCH 29/54] feat: custom arguments are now closable

---
 .../components/LaunchArgumentsSelector.vue    | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 722c39705..e0d17a874 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -18,7 +18,11 @@
             </el-tooltip>
 
             <!-- Custom arguments -->
-            <el-tag v-else>
+            <el-tag
+                v-else
+                closable
+                @close="onClose(index, argument.argumentName)"
+            >
                 {{ argument.argumentName }}
             </el-tag>
         </div>
@@ -124,6 +128,20 @@ export default defineComponent({
             this.values[index] = !this.values[index];
             this.saveLaunchArgumentsToFile();
         },
+        onClose(index: number, argumentName: string) {
+            // remove item state value
+            this.values.splice(index, 1);
+
+            // remove item from list of custom arguments
+            const localIndex = this.localCustomArgs.map(arg => arg.argumentName).indexOf(argumentName);
+            if (localIndex === -1) {
+                console.error(`Failed removing argument "${argumentName}".`);
+                return;
+            }
+            this.localCustomArgs.splice(localIndex, 1);
+
+            this.saveLaunchArgumentsToFile();
+        },
         saveLaunchArgumentsToFile() {
             const newArgs = this.arguments
                 .filter((value: LaunchArgument, index: number) => {

From 32c1118651dec8b80ae629b77361ca53ec7768ae Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Mon, 8 May 2023 18:04:58 +0200
Subject: [PATCH 30/54] feat: use same style for all argument HTML elements

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index e0d17a874..f00b24a96 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -199,6 +199,20 @@ export default defineComponent({
     transform: translateX(-8px);
 }
 
+.el-tag {
+    background-color: var(--el-color-primary-light-8);
+    color: var(--el-color-primary);
+    font-size: var(--el-font-size-base);
+    line-height: var(--el-font-size-base);
+    padding: 14px 5px 12px 15px;
+    transition: var(--el-transition-all);
+    font-weight: 700;
+}
+
+.el-check-tag {
+    padding: 9px 15px 5px 15px;
+}
+
 .disabled_container {
     pointer-events: none;
     filter: grayscale();

From b2540588fd52c74bcbdcba650b3761d462fcfd63 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Mon, 8 May 2023 18:37:00 +0200
Subject: [PATCH 31/54] refactor: adjust positioning of argument inputs

---
 .../components/LaunchArgumentsSelector.vue    | 105 ++++++++++--------
 1 file changed, 59 insertions(+), 46 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index f00b24a96..ccf18f447 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,55 +1,66 @@
 <template>
-    <div :class="containerClasses">
-        <div class="fc-launch_arg_tag_container" 
-                v-for="(argument, index) in arguments">
-            <!-- Official arguments -->
-            <el-tooltip
-                v-if="argument.i18nEntry.length !== 0"
-                class="box-item"
-                :content="$t(argument.i18nEntry)"
-                placement="bottom"
-            >
-                <el-check-tag
-                    :checked="values[index]"
-                    @change="onChange(index)"
+    <div>
+        <div :class="containerClasses">
+            <div class="fc-launch_arg_tag_container" 
+                    v-for="(argument, index) in arguments">
+                <!-- Official arguments -->
+                <el-tooltip
+                    v-if="argument.i18nEntry.length !== 0"
+                    class="box-item"
+                    :content="$t(argument.i18nEntry)"
+                    placement="bottom"
+                >
+                    <el-check-tag
+                        :checked="values[index]"
+                        @change="onChange(index)"
+                    >
+                        {{ argument.argumentName }}
+                    </el-check-tag>
+                </el-tooltip>
+
+                <!-- Custom arguments -->
+                <el-tag
+                    v-else
+                    closable
+                    @close="onClose(index, argument.argumentName)"
                 >
                     {{ argument.argumentName }}
-                </el-check-tag>
-            </el-tooltip>
-
-            <!-- Custom arguments -->
-            <el-tag
-                v-else
-                closable
-                @close="onClose(index, argument.argumentName)"
-            >
-                {{ argument.argumentName }}
-            </el-tag>
+                </el-tag>
+            </div>
+
+            <!-- User-input tag -->
+            <div class="fc-launch_arg_tag_container">
+                <el-input
+                    v-if="inputVisible"
+                    ref="InputRef"
+                    class="fc-tag__input"
+                    v-model="inputValue"
+                    @keyup.enter="handleInputConfirm"
+                    @blur="handleInputConfirm"
+                />
+                <el-button v-else class="button-new-tag ml-1 fc-tag__input" @click="showInput">
+                    {{ $t('settings.launch_args.new_arg_btn') }}
+                </el-button>
+            </div>
         </div>
 
+
         <!-- Language selector -->
-        <el-select v-if="displayLanguageSelector" v-model="langArgumentValue" class="m-2" placeholder="-lang=" @change="onLanguageSelection">
-            <el-option
-                v-for="item in langArgumentOptions"
-                :key="item.value"
-                :label="item.label"
-                :value="item.value"
-            />
-        </el-select>
-
-        <!-- User-input tag -->
-        <el-input
-            v-if="inputVisible"
-            ref="InputRef"
-            class="fc-tag__input"
-            v-model="inputValue"
-            size="small"
-            @keyup.enter="handleInputConfirm"
-            @blur="handleInputConfirm"
-        />
-        <el-button v-else class="button-new-tag ml-1" size="small" @click="showInput">
-            {{ $t('settings.launch_args.new_arg_btn') }}
-        </el-button>
+        <div :class="containerClasses">
+            <el-select v-if="displayLanguageSelector"
+                v-model="langArgumentValue"
+                class="m-2 fc-launch_arg_tag_container fc-tag__input"
+                placeholder="-lang="
+                @change="onLanguageSelection"
+            >
+                <el-option
+                    v-for="item in langArgumentOptions"
+                    :key="item.value"
+                    :label="item.label"
+                    :value="item.value"
+                />
+            </el-select>
+        </div>
     </div>
 </template>
 
@@ -220,5 +231,7 @@ export default defineComponent({
 
 .fc-tag__input {
     width: auto;
+    height: 28px;
+    --el-component-size: 28px;
 }
 </style>

From d9bf227e64faf243a47fa9058ffaa22c624b4cbb Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Mon, 8 May 2023 18:43:40 +0200
Subject: [PATCH 32/54] refactor: translate argument input placeholder

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 2 +-
 src-vue/src/i18n/lang/en.json                      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index ccf18f447..e19fdf612 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -50,7 +50,7 @@
             <el-select v-if="displayLanguageSelector"
                 v-model="langArgumentValue"
                 class="m-2 fc-launch_arg_tag_container fc-tag__input"
-                placeholder="-lang="
+                :placeholder="$t('settings.launch_args.select_game_language')"
                 @change="onLanguageSelection"
             >
                 <el-option
diff --git a/src-vue/src/i18n/lang/en.json b/src-vue/src/i18n/lang/en.json
index 99a86b5b2..1ff97f2df 100644
--- a/src-vue/src/i18n/lang/en.json
+++ b/src-vue/src/i18n/lang/en.json
@@ -127,6 +127,7 @@
         "launch_args": {
             "title": "Launch arguments",
             "new_arg_btn": "+ New launch argument",
+            "select_game_language": "Select game language",
             "descriptions": {
                 "disablelogs": "Disable logging and creation of log files",
                 "vanilla": "Disables Northstar loading",

From 52dfaa57e3dad7a1cc5b8b5872048b5ee4a93fab Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Mon, 8 May 2023 18:45:56 +0200
Subject: [PATCH 33/54] fix: reset language input model on language selection

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index e19fdf612..51a2d438f 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -120,6 +120,7 @@ export default defineComponent({
     methods: {
         onLanguageSelection( lang: string ) {
             this.createNewArgument( `-language="${lang}"` );
+            this.langArgumentValue = '';
         },
         createNewArgument(arg: string) {
             let allArgumentsNames: string[] = this.arguments.map(arg => arg.argumentName);

From 15bdcde17f0f40313d3bc709ae1c535e5fcbeaca Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 11 May 2023 08:25:44 +0200
Subject: [PATCH 34/54] refactor: remove map operator from set_launch_arguments
 method

---
 src-tauri/src/northstar/launch_arguments.rs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 9ff5e99d7..38fbb9647 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -29,12 +29,12 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 /// If the ns_startup_args.txt file does not exist, this will create it.
 pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
     let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
+    let write_result = std::fs::write(launch_args_path.clone(), arguments.join(" "));
     
-    match std::fs::write(launch_args_path.clone(), arguments.join(" ")) {
-        Ok(..) => (),
-        Err(_) => return Err("Failed to save launch arguments.".to_string()),
+    if write_result.is_ok() {
+        log::info!("Launch arguments updated.");
+        return Ok(());
+    } else {
+        return Err("Failed to save launch arguments.".to_string());
     }
-
-    log::info!("Launch arguments updated.");
-    Ok(())
 }

From bd369274abf34e2544838dd857dfc2649adca7f5 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 11 May 2023 19:12:44 +0200
Subject: [PATCH 35/54] refactor: use `if let` syntax to catch error in
 set_launch_arguments method

---
 src-tauri/src/northstar/launch_arguments.rs | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 38fbb9647..6d5dbe735 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -28,13 +28,10 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 /// launch arguments files.
 /// If the ns_startup_args.txt file does not exist, this will create it.
 pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
-    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
-    let write_result = std::fs::write(launch_args_path.clone(), arguments.join(" "));
-    
-    if write_result.is_ok() {
-        log::info!("Launch arguments updated.");
-        return Ok(());
-    } else {
+    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);    
+    if let Err(_) = std::fs::write(launch_args_path.clone(), arguments.join(" ")) {
         return Err("Failed to save launch arguments.".to_string());
     }
+    log::info!("Launch arguments updated.");
+    return Ok(());
 }

From 936f70c78aada535a9ecf9337dcd297909731a44 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 11 May 2023 19:14:43 +0200
Subject: [PATCH 36/54] style: fix fmt warnings

---
 src-tauri/src/northstar/launch_arguments.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 6d5dbe735..f96d59917 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -15,7 +15,8 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
         }
     };
 
-    let mut arguments = data.split_whitespace()
+    let mut arguments = data
+        .split_whitespace()
         .map(|arg| arg.to_string())
         .collect::<Vec<_>>();
     arguments.sort_unstable();
@@ -28,7 +29,7 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 /// launch arguments files.
 /// If the ns_startup_args.txt file does not exist, this will create it.
 pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
-    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);    
+    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
     if let Err(_) = std::fs::write(launch_args_path.clone(), arguments.join(" ")) {
         return Err("Failed to save launch arguments.".to_string());
     }

From a266c3e098828884495efac900de5459a5f419d9 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 11 May 2023 19:17:53 +0200
Subject: [PATCH 37/54] style: fix clippy warnings

---
 src-tauri/src/northstar/launch_arguments.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index f96d59917..f3fe46579 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -8,7 +8,7 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
         return Ok(vec![]);
     }
 
-    let data = match std::fs::read_to_string(launch_args_path.clone()) {
+    let data = match std::fs::read_to_string(launch_args_path) {
         Ok(content) => content,
         Err(_) => {
             return Ok(vec![]);
@@ -30,9 +30,9 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
 /// If the ns_startup_args.txt file does not exist, this will create it.
 pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
     let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
-    if let Err(_) = std::fs::write(launch_args_path.clone(), arguments.join(" ")) {
+    if std::fs::write(launch_args_path, arguments.join(" ")).is_err() {
         return Err("Failed to save launch arguments.".to_string());
     }
     log::info!("Launch arguments updated.");
-    return Ok(());
+    Ok(())
 }

From fd89d601d2280eb0829d95c2a75184c7cba2d9e6 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 11 May 2023 22:14:59 +0200
Subject: [PATCH 38/54] feat: remove tag transitions

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 51a2d438f..58391612f 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -22,6 +22,7 @@
                 <el-tag
                     v-else
                     closable
+                    disable-transitions
                     @close="onClose(index, argument.argumentName)"
                 >
                     {{ argument.argumentName }}
@@ -223,6 +224,7 @@ export default defineComponent({
 
 .el-check-tag {
     padding: 9px 15px 5px 15px;
+    transition: none;
 }
 
 .disabled_container {

From 62493a64986106a96a33c2f6e4396b258bf2e092 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20Raes?= <contact@remyraes.com>
Date: Fri, 7 Jul 2023 22:15:03 +0200
Subject: [PATCH 39/54] fix: remove old function import

---
 src-tauri/src/main.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs
index 7144a87a9..8d90b961a 100644
--- a/src-tauri/src/main.rs
+++ b/src-tauri/src/main.rs
@@ -121,7 +121,6 @@ fn main() {
             util::force_panic,
             northstar::install::find_game_install_location,
             get_flightcore_version_number,
-            get_northstar_version_number_caller,
             northstar::launch_arguments::get_launch_arguments,
             northstar::launch_arguments::set_launch_arguments,
             northstar::get_northstar_version_number,

From ee303a189ad7ff1c8a2d40f7e97325e1504c4dc7 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sat, 8 Jul 2023 16:45:06 +0200
Subject: [PATCH 40/54] fix: create language argument with whitespace between
 argument key and value

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 58391612f..6727abf00 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -1,7 +1,7 @@
 <template>
     <div>
         <div :class="containerClasses">
-            <div class="fc-launch_arg_tag_container" 
+            <div class="fc-launch_arg_tag_container"
                     v-for="(argument, index) in arguments">
                 <!-- Official arguments -->
                 <el-tooltip
@@ -120,7 +120,7 @@ export default defineComponent({
     }),
     methods: {
         onLanguageSelection( lang: string ) {
-            this.createNewArgument( `-language="${lang}"` );
+            this.createNewArgument( `-language ${lang}` );
             this.langArgumentValue = '';
         },
         createNewArgument(arg: string) {

From 7383bd5de6fdef9839e8f0a99ff37e725b355f74 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 9 Jul 2023 19:18:21 +0200
Subject: [PATCH 41/54] feat: look for language argument value

---
 src-tauri/src/northstar/launch_arguments.rs | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index f3fe46579..4d177815f 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -19,6 +19,18 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
         .split_whitespace()
         .map(|arg| arg.to_string())
         .collect::<Vec<_>>();
+
+    // associate language argument
+    let index = arguments.iter().position(|r| r == "-language").unwrap_or_else(|| { usize::MAX });
+    if index != usize::MAX {
+        let value_index = index + 1;
+        if value_index > arguments.len()-1 {
+            println!("-language argument has no associated value.");
+        } else {
+            println!("{}", value_index);
+        }
+    }
+
     arguments.sort_unstable();
     arguments.dedup();
     Ok(arguments)

From 65488cd90451a570606e20c9e0025d7b91812d22 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Sun, 9 Jul 2023 21:53:51 +0200
Subject: [PATCH 42/54] feat: associate language key and value

---
 src-tauri/src/northstar/launch_arguments.rs | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
index 4d177815f..3f853a4e2 100644
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ b/src-tauri/src/northstar/launch_arguments.rs
@@ -1,3 +1,5 @@
+const SUPPORTED_LANGUAGES: [&str; 10] = ["english", "french", "german", "italian", "japanese", "mspanish", "portuguese", "russian", "spanish", "tchinese"];
+
 #[tauri::command]
 /// This method loads arguments from the ns_startup_args.txt Northstar launch
 /// arguments files, filtering out eventual argument duplicates.
@@ -27,7 +29,18 @@ pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
         if value_index > arguments.len()-1 {
             println!("-language argument has no associated value.");
         } else {
-            println!("{}", value_index);
+            // Check if argument is a valid language value
+            let value = arguments.get(value_index).unwrap();
+            let language_value_index = SUPPORTED_LANGUAGES.iter().position(|s| s == value).unwrap_or_else(|| { usize::MAX });
+            if language_value_index == usize::MAX {
+                println!("-language argument is not among supported languages.");
+            } else {
+                // Join language key and value into a single argument
+                let language_key = arguments.remove(index);
+                let language_value = arguments.remove(index);
+                let new_argument = format!("{language_key} {language_value}");
+                arguments.insert(index, new_argument);
+            }
         }
     }
 

From 54f68bca78c057b281c5c13f83964358c5742ee2 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Wed, 26 Jul 2023 08:13:30 +0200
Subject: [PATCH 43/54] fix: do not display language selector if a language
 argument is already there

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 6727abf00..74d3b7774 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -80,7 +80,8 @@ export default defineComponent({
                 .sort((a, b) => a.argumentName.localeCompare(b.argumentName));
         },
         displayLanguageSelector(): boolean {
-            const langArgPrefix = '-language="';
+            const langArgPrefix = '-language ';
+            console.log(this.arguments);
             return this.arguments
                 .map(arg => arg.argumentName)
                 .filter(name => name.substring(0, langArgPrefix.length) === langArgPrefix)

From 0c6369e969cc8f377694ac55da38e5a32ed4a42c Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 9 Jan 2024 23:27:54 +0100
Subject: [PATCH 44/54] feat: store launch arguments in persistent store

---
 .../components/LaunchArgumentsSelector.vue    | 28 +++++++++++++------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index f397a680f..0a081d634 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -71,6 +71,10 @@ import { LaunchArgument } from '../utils/LaunchArgument';
 import { NorthstarState } from '../utils/NorthstarState';
 import {invoke} from "@tauri-apps/api";
 import { showErrorNotification } from '../utils/ui';
+import { Store } from 'tauri-plugin-store-api';
+
+const persistentStore = new Store('flight-core-settings.json');
+const argumentsStoreKey = 'launch_arguments';
 
 export default defineComponent({
     name: 'LaunchArgumentsSelector',
@@ -81,7 +85,6 @@ export default defineComponent({
         },
         displayLanguageSelector(): boolean {
             const langArgPrefix = '-language ';
-            console.log(this.arguments);
             return this.arguments
                 .map(arg => arg.argumentName)
                 .filter(name => name.substring(0, langArgPrefix.length) === langArgPrefix)
@@ -161,13 +164,15 @@ export default defineComponent({
                 .filter((value: LaunchArgument, index: number) => {
                     return this.values[index];
                 })
-                .map((value: LaunchArgument) => value.argumentName)
-
-            invoke<string[]>("set_launch_arguments", {
-                gamePath: this.$store.state.game_install.game_path, arguments: newArgs
-            }).catch((err: any) => {
-                showErrorNotification(err);
-            });
+                .map((value: LaunchArgument) => value.argumentName);
+            
+            persistentStore.set(argumentsStoreKey, newArgs)
+                .then(() => {
+                    console.log("Launch arguments updated.");
+                })
+                .catch((err: any) => {
+                    showErrorNotification(err);
+                });
         },
         showInput() {
             this.inputVisible = true;
@@ -187,8 +192,13 @@ export default defineComponent({
     async mounted() {
         this.values = this.arguments.map(a => false);
 
+        const fileArgs: string[] | null = await persistentStore.get(argumentsStoreKey);
+        if (fileArgs === null) {
+            console.log('No local launch arguments to load, exiting.');
+            return;
+        }
+
         // Only add to local arguments those who are not in official arguments array
-        const fileArgs = await invoke<string[]>("get_launch_arguments", { gamePath: this.$store.state.game_install.game_path});
         this.localCustomArgs = fileArgs
             .filter(arg => this.officialArguments.map(oArg => oArg.argumentName).indexOf(arg) === -1)
             .map(arg => new LaunchArgument(arg));

From 7ef6c116280789438f4e8364fd44e932cf0b1ef3 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Thu, 11 Jan 2024 17:57:51 +0100
Subject: [PATCH 45/54] refactor: remove unused rust package

---
 src-tauri/src/main.rs                       |  2 -
 src-tauri/src/northstar/launch_arguments.rs | 63 ---------------------
 src-tauri/src/northstar/mod.rs              |  1 -
 3 files changed, 66 deletions(-)
 delete mode 100644 src-tauri/src/northstar/launch_arguments.rs

diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs
index 175a267c3..09242680b 100644
--- a/src-tauri/src/main.rs
+++ b/src-tauri/src/main.rs
@@ -118,8 +118,6 @@ fn main() {
         .invoke_handler(tauri::generate_handler![
             util::force_panic,
             northstar::install::find_game_install_location,
-            northstar::launch_arguments::get_launch_arguments,
-            northstar::launch_arguments::set_launch_arguments,
             util::get_flightcore_version_number,
             northstar::get_northstar_version_number,
             northstar::check_is_northstar_outdated,
diff --git a/src-tauri/src/northstar/launch_arguments.rs b/src-tauri/src/northstar/launch_arguments.rs
deleted file mode 100644
index 3f853a4e2..000000000
--- a/src-tauri/src/northstar/launch_arguments.rs
+++ /dev/null
@@ -1,63 +0,0 @@
-const SUPPORTED_LANGUAGES: [&str; 10] = ["english", "french", "german", "italian", "japanese", "mspanish", "portuguese", "russian", "spanish", "tchinese"];
-
-#[tauri::command]
-/// This method loads arguments from the ns_startup_args.txt Northstar launch
-/// arguments files, filtering out eventual argument duplicates.
-/// If this file does not exist, this will return an empty array.
-pub fn get_launch_arguments(game_path: &str) -> Result<Vec<String>, ()> {
-    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
-    if !std::path::Path::new(&launch_args_path).exists() {
-        return Ok(vec![]);
-    }
-
-    let data = match std::fs::read_to_string(launch_args_path) {
-        Ok(content) => content,
-        Err(_) => {
-            return Ok(vec![]);
-        }
-    };
-
-    let mut arguments = data
-        .split_whitespace()
-        .map(|arg| arg.to_string())
-        .collect::<Vec<_>>();
-
-    // associate language argument
-    let index = arguments.iter().position(|r| r == "-language").unwrap_or_else(|| { usize::MAX });
-    if index != usize::MAX {
-        let value_index = index + 1;
-        if value_index > arguments.len()-1 {
-            println!("-language argument has no associated value.");
-        } else {
-            // Check if argument is a valid language value
-            let value = arguments.get(value_index).unwrap();
-            let language_value_index = SUPPORTED_LANGUAGES.iter().position(|s| s == value).unwrap_or_else(|| { usize::MAX });
-            if language_value_index == usize::MAX {
-                println!("-language argument is not among supported languages.");
-            } else {
-                // Join language key and value into a single argument
-                let language_key = arguments.remove(index);
-                let language_value = arguments.remove(index);
-                let new_argument = format!("{language_key} {language_value}");
-                arguments.insert(index, new_argument);
-            }
-        }
-    }
-
-    arguments.sort_unstable();
-    arguments.dedup();
-    Ok(arguments)
-}
-
-#[tauri::command]
-/// This method puts an array of arguments into the ns_startup_args.txt Northstar
-/// launch arguments files.
-/// If the ns_startup_args.txt file does not exist, this will create it.
-pub fn set_launch_arguments(game_path: &str, arguments: Vec<String>) -> Result<(), String> {
-    let launch_args_path = format!("{}/ns_startup_args.txt", game_path);
-    if std::fs::write(launch_args_path, arguments.join(" ")).is_err() {
-        return Err("Failed to save launch arguments.".to_string());
-    }
-    log::info!("Launch arguments updated.");
-    Ok(())
-}
diff --git a/src-tauri/src/northstar/mod.rs b/src-tauri/src/northstar/mod.rs
index d12a81f7c..e707849e9 100644
--- a/src-tauri/src/northstar/mod.rs
+++ b/src-tauri/src/northstar/mod.rs
@@ -11,7 +11,6 @@ use crate::{
 };
 use crate::{NorthstarThunderstoreRelease, NorthstarThunderstoreReleaseWrapper};
 use anyhow::anyhow;
-pub mod launch_arguments;
 
 /// Gets list of available Northstar versions from Thunderstore
 #[tauri::command]

From 073ddeb759f31dda1c4d4672265ff3418d177933 Mon Sep 17 00:00:00 2001
From: Remy Raes <contact@remyraes.com>
Date: Tue, 16 Jan 2024 18:21:56 +0100
Subject: [PATCH 46/54] fix: save arguments in store on argument change

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 0a081d634..2a942f0a3 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -167,7 +167,8 @@ export default defineComponent({
                 .map((value: LaunchArgument) => value.argumentName);
             
             persistentStore.set(argumentsStoreKey, newArgs)
-                .then(() => {
+                .then(async () => {
+                    await persistentStore.save();
                     console.log("Launch arguments updated.");
                 })
                 .catch((err: any) => {

From 16107b6c596acd58de041663b3d08409b290b7bc Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 15:32:59 +0100
Subject: [PATCH 47/54] refactor: move store key to main package

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 4 ++--
 src-vue/src/main.ts                                | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 2a942f0a3..3cb3d5d27 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -72,9 +72,9 @@ import { NorthstarState } from '../utils/NorthstarState';
 import {invoke} from "@tauri-apps/api";
 import { showErrorNotification } from '../utils/ui';
 import { Store } from 'tauri-plugin-store-api';
+import {argumentsStoreKey} from "../main";
 
 const persistentStore = new Store('flight-core-settings.json');
-const argumentsStoreKey = 'launch_arguments';
 
 export default defineComponent({
     name: 'LaunchArgumentsSelector',
@@ -165,7 +165,7 @@ export default defineComponent({
                     return this.values[index];
                 })
                 .map((value: LaunchArgument) => value.argumentName);
-            
+
             persistentStore.set(argumentsStoreKey, newArgs)
                 .then(async () => {
                     await persistentStore.save();
diff --git a/src-vue/src/main.ts b/src-vue/src/main.ts
index 73219c9d7..60eb337d3 100644
--- a/src-vue/src/main.ts
+++ b/src-vue/src/main.ts
@@ -64,5 +64,7 @@ export const router = createRouter({
 });
 app.use(router);
 
+// Store keys
+export const argumentsStoreKey = 'launch_arguments';
 
 app.mount('#app')

From ce438fe5c7b5c3ebb21b8cc5e1fbbb341e9dbe3a Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 15:42:34 +0100
Subject: [PATCH 48/54] fix: container grayscale filter

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index 3cb3d5d27..f25a6dfbd 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -241,7 +241,7 @@ export default defineComponent({
 
 .disabled_container {
     pointer-events: none;
-    filter: grayscale();
+    filter: grayscale(1);
 }
 
 .fc-tag__input {

From 0bccb19e8ead3f47be79beecf505a039cd50628a Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 16:06:09 +0100
Subject: [PATCH 49/54] feat: pass launch arguments to backend

---
 src-tauri/src/northstar/mod.rs |  2 ++
 src-vue/src/plugins/store.ts   | 14 ++++++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/src-tauri/src/northstar/mod.rs b/src-tauri/src/northstar/mod.rs
index ea4f4cde1..3af5a2ead 100644
--- a/src-tauri/src/northstar/mod.rs
+++ b/src-tauri/src/northstar/mod.rs
@@ -154,10 +154,12 @@ pub fn get_northstar_version_number(game_install: GameInstall) -> Result<String,
 #[tauri::command]
 pub fn launch_northstar(
     game_install: GameInstall,
+    launch_args: Vec<String>,
     launch_via_steam: Option<bool>,
     bypass_checks: Option<bool>,
 ) -> Result<String, String> {
     dbg!(game_install.clone());
+    println!("Launch arguments: {:?}", launch_args);
 
     let launch_via_steam = launch_via_steam.unwrap_or(false);
     if launch_via_steam {
diff --git a/src-vue/src/plugins/store.ts b/src-vue/src/plugins/store.ts
index a1a67e2b8..e69a65050 100644
--- a/src-vue/src/plugins/store.ts
+++ b/src-vue/src/plugins/store.ts
@@ -11,7 +11,7 @@ import { NorthstarState } from '../utils/NorthstarState';
 import { appDir } from '@tauri-apps/api/path';
 import { open } from '@tauri-apps/api/dialog';
 import { Store } from 'tauri-plugin-store-api';
-import { router } from "../main";
+import {argumentsStoreKey, router} from "../main";
 import { ReleaseInfo } from "../../../src-tauri/bindings/ReleaseInfo";
 import { ThunderstoreMod } from "../../../src-tauri/bindings/ThunderstoreMod";
 import { NorthstarMod } from "../../../src-tauri/bindings/NorthstarMod";
@@ -173,8 +173,11 @@ export const store = createStore<FlightCoreStore>({
             }
         },
         async launchGame(state: any, no_checks = false) {
+            // Launch arguments
+            const fileArgs: string[] = await persistentStore.get(argumentsStoreKey) ?? [];
+
             if (no_checks) {
-                await invoke("launch_northstar", { gameInstall: state.game_install, bypassChecks: no_checks })
+                await invoke("launch_northstar", { gameInstall: state.game_install, launchArgs: fileArgs, bypassChecks: no_checks })
                     .then((message) => {
                         console.log("Launched with bypassed checks");
                         console.log(message);
@@ -224,7 +227,7 @@ export const store = createStore<FlightCoreStore>({
 
                 // Game is ready to play.
                 case NorthstarState.READY_TO_PLAY:
-                    await invoke("launch_northstar", { gameInstall: state.game_install })
+                    await invoke("launch_northstar", { gameInstall: state.game_install, launchArgs: fileArgs })
                         .then((message) => {
                             console.log(message);
                             // NorthstarState.RUNNING
@@ -241,7 +244,10 @@ export const store = createStore<FlightCoreStore>({
             }
         },
         async launchGameSteam(state: any, no_checks = false) {
-            await invoke("launch_northstar", { gameInstall: state.game_install, launchViaSteam: true, bypassChecks: no_checks })
+            // Launch arguments
+            const fileArgs: string[] = await persistentStore.get(argumentsStoreKey) ?? [];
+
+            await invoke("launch_northstar", { gameInstall: state.game_install, launchArgs: fileArgs, launchViaSteam: true, bypassChecks: no_checks })
                 .then((message) => {
                     showNotification('Success');
                 })

From ab6de2246f35481feee1966f5155fb7a1d2a5c42 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 17:10:01 +0100
Subject: [PATCH 50/54] fix: language argument format

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index f25a6dfbd..c87ae9444 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -84,7 +84,7 @@ export default defineComponent({
                 .sort((a, b) => a.argumentName.localeCompare(b.argumentName));
         },
         displayLanguageSelector(): boolean {
-            const langArgPrefix = '-language ';
+            const langArgPrefix = '-language=';
             return this.arguments
                 .map(arg => arg.argumentName)
                 .filter(name => name.substring(0, langArgPrefix.length) === langArgPrefix)
@@ -124,7 +124,7 @@ export default defineComponent({
     }),
     methods: {
         onLanguageSelection( lang: string ) {
-            this.createNewArgument( `-language ${lang}` );
+            this.createNewArgument( `-language=${lang}` );
             this.langArgumentValue = '';
         },
         createNewArgument(arg: string) {

From 6525b7dfa3eb0bc3afc2679add53d61e7aa61a84 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 17:30:30 +0100
Subject: [PATCH 51/54] fix: adjust language selector width

---
 src-vue/src/components/LaunchArgumentsSelector.vue | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src-vue/src/components/LaunchArgumentsSelector.vue b/src-vue/src/components/LaunchArgumentsSelector.vue
index c87ae9444..436b65b16 100644
--- a/src-vue/src/components/LaunchArgumentsSelector.vue
+++ b/src-vue/src/components/LaunchArgumentsSelector.vue
@@ -224,6 +224,10 @@ export default defineComponent({
     transform: translateX(-8px);
 }
 
+.fc-tags_container .el-select {
+    min-width: 222px;
+}
+
 .el-tag {
     background-color: var(--el-color-primary-light-8);
     color: var(--el-color-primary);

From ebe67f192d752e98c473c0070d4e9ef7feb0959c Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 18:24:17 +0100
Subject: [PATCH 52/54] feat: pass arguments when launching game

---
 src-tauri/src/northstar/mod.rs | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src-tauri/src/northstar/mod.rs b/src-tauri/src/northstar/mod.rs
index 3af5a2ead..992d5d1b2 100644
--- a/src-tauri/src/northstar/mod.rs
+++ b/src-tauri/src/northstar/mod.rs
@@ -163,7 +163,7 @@ pub fn launch_northstar(
 
     let launch_via_steam = launch_via_steam.unwrap_or(false);
     if launch_via_steam {
-        return launch_northstar_steam(game_install, bypass_checks);
+        return launch_northstar_steam(game_install, launch_args, bypass_checks);
     }
 
     let host_os = get_host_os();
@@ -178,7 +178,7 @@ pub fn launch_northstar(
             ));
         }
 
-        return launch_northstar_steam(game_install, bypass_checks);
+        return launch_northstar_steam(game_install, launch_args, bypass_checks);
     }
 
     let bypass_checks = bypass_checks.unwrap_or(false);
@@ -214,9 +214,10 @@ pub fn launch_northstar(
     {
         let ns_exe_path = format!("{}/NorthstarLauncher.exe", game_install.game_path);
         let ns_profile_arg = format!("-profile={}", game_install.profile);
+        let args_str = &launch_args.join(" ");
 
         let _output = std::process::Command::new("C:\\Windows\\System32\\cmd.exe")
-            .args(["/C", "start", "", &ns_exe_path, &ns_profile_arg])
+            .args(["/C", "start", "", &ns_exe_path, &ns_profile_arg, args_str])
             .spawn()
             .expect("failed to execute process");
         return Ok("Launched game".to_string());
@@ -232,6 +233,7 @@ pub fn launch_northstar(
 /// Prepare Northstar and Launch through Steam using the Browser Protocol
 pub fn launch_northstar_steam(
     game_install: GameInstall,
+    launch_args: Vec<String>,
     _bypass_checks: Option<bool>,
 ) -> Result<String, String> {
     if !matches!(game_install.install_type, InstallType::STEAM) {
@@ -264,8 +266,8 @@ pub fn launch_northstar_steam(
     }
 
     match open::that(format!(
-        "steam://run/{}//-profile={} --northstar/",
-        TITANFALL2_STEAM_ID, game_install.profile
+        "steam://run/{}//-profile={} --northstar/ {}",
+        TITANFALL2_STEAM_ID, game_install.profile, launch_args.join(" ")
     )) {
         Ok(()) => Ok("Started game".to_string()),
         Err(_err) => Err("Failed to launch Titanfall 2 via Steam".to_string()),

From 5e76d474466762a52a5a7ace5e9dbf9796303910 Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 18:28:46 +0100
Subject: [PATCH 53/54] style: formatting

---
 src-tauri/src/northstar/mod.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src-tauri/src/northstar/mod.rs b/src-tauri/src/northstar/mod.rs
index 992d5d1b2..4ab2123ae 100644
--- a/src-tauri/src/northstar/mod.rs
+++ b/src-tauri/src/northstar/mod.rs
@@ -267,7 +267,9 @@ pub fn launch_northstar_steam(
 
     match open::that(format!(
         "steam://run/{}//-profile={} --northstar/ {}",
-        TITANFALL2_STEAM_ID, game_install.profile, launch_args.join(" ")
+        TITANFALL2_STEAM_ID,
+        game_install.profile,
+        launch_args.join(" ")
     )) {
         Ok(()) => Ok("Started game".to_string()),
         Err(_err) => Err("Failed to launch Titanfall 2 via Steam".to_string()),

From 2a4fc2fbf34f5be3cdeb5031efbb17420a74cfbc Mon Sep 17 00:00:00 2001
From: Remy Raes <raes.remy@gmail.com>
Date: Sun, 28 Jan 2024 19:01:24 +0100
Subject: [PATCH 54/54] fix: treat arguments as references

---
 src-tauri/src/northstar/mod.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src-tauri/src/northstar/mod.rs b/src-tauri/src/northstar/mod.rs
index 4ab2123ae..1f64f3405 100644
--- a/src-tauri/src/northstar/mod.rs
+++ b/src-tauri/src/northstar/mod.rs
@@ -154,7 +154,7 @@ pub fn get_northstar_version_number(game_install: GameInstall) -> Result<String,
 #[tauri::command]
 pub fn launch_northstar(
     game_install: GameInstall,
-    launch_args: Vec<String>,
+    launch_args: Vec<&str>,
     launch_via_steam: Option<bool>,
     bypass_checks: Option<bool>,
 ) -> Result<String, String> {
@@ -214,10 +214,11 @@ pub fn launch_northstar(
     {
         let ns_exe_path = format!("{}/NorthstarLauncher.exe", game_install.game_path);
         let ns_profile_arg = format!("-profile={}", game_install.profile);
-        let args_str = &launch_args.join(" ");
+        let mut arguments = vec!["/C", "start", "", &ns_exe_path, &ns_profile_arg];
+        arguments.extend(launch_args);
 
         let _output = std::process::Command::new("C:\\Windows\\System32\\cmd.exe")
-            .args(["/C", "start", "", &ns_exe_path, &ns_profile_arg, args_str])
+            .args(arguments)
             .spawn()
             .expect("failed to execute process");
         return Ok("Launched game".to_string());
@@ -233,7 +234,7 @@ pub fn launch_northstar(
 /// Prepare Northstar and Launch through Steam using the Browser Protocol
 pub fn launch_northstar_steam(
     game_install: GameInstall,
-    launch_args: Vec<String>,
+    launch_args: Vec<&str>,
     _bypass_checks: Option<bool>,
 ) -> Result<String, String> {
     if !matches!(game_install.install_type, InstallType::STEAM) {