Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release epidict 0.1.0 #7

Open
10 of 20 tasks
zkamvar opened this issue Feb 10, 2020 · 7 comments
Open
10 of 20 tasks

Release epidict 0.1.0 #7

zkamvar opened this issue Feb 10, 2020 · 7 comments

Comments

@zkamvar
Copy link
Member

zkamvar commented Feb 10, 2020

Prepare for release:

  • Check that description is informative
  • Check licensing of included files
  • usethis::use_cran_comments()
  • devtools::check()
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • Create vignettes
  • Polish pkgdown reference index
  • Draft blog post

Submit to CRAN:

  • usethis::use_version('minor')
  • Update cran-comments.md
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_dev_version()
  • Update install instructions in README
  • Finish blog post
  • Tweet
  • Add link to blog post in pkgdown news menu
@zkamvar zkamvar mentioned this issue Feb 10, 2020
@aspina7
Copy link
Member

aspina7 commented Feb 11, 2020

Index:

  • could say something like: "This package provides standardized data dictionaries for four outbreak scenarios (Acute Jaundice Syndrome, Cholera, Measles, Meningitis) and three surveys (Retrospective mortality and access to care, Malnutrition, and Vaccination coverage) - currently based on MSF OCA dictionaries - other dictionaries are planned to be added shortly"

gen_data:

  • all fine, examples a bit dense but assume that all the extra bits around dont show up on the user faacing side - all the withAutoprint stuff?
    image

msf_dict:

  • description: "The randomised dataset produced should mimic an excel export from DHIS2 for outbreaks and a Kobo export for surveys".
  • arguments: disease: missing the survey options!
  • same thing with examples as above (ignore if relevant)

website: good

otherwise peng

@zkamvar
Copy link
Member Author

zkamvar commented Feb 11, 2020

* all fine, examples a bit dense but assume that all the extra bits around dont show up on the user faacing side - all the withAutoprint stuff?

@aspina7, If we don't include the withAutoprint stuff, then the examples won't show up well on the site (they would only see the data sets print out sequentially).

@zkamvar
Copy link
Member Author

zkamvar commented Feb 11, 2020

[ ] arguments: disease: missing the survey options!

@aspina7, what do you mean here?

@aspina7
Copy link
Member

aspina7 commented Feb 11, 2020

[ ] arguments: disease: missing the survey options!
@aspina7, what do you mean here?

In the arguments section for diseases - it only lists measles ajs and cholera, but should also specify that for the survey dictionaries the options are mortality, vaccination, nutrition etc...

@zkamvar
Copy link
Member Author

zkamvar commented Feb 11, 2020

[ ] arguments: disease: missing the survey options!
@aspina7, what do you mean here?

In the arguments section for diseases - it only lists measles ajs and cholera, but should also specify that for the survey dictionaries the options are mortality, vaccination, nutrition etc...

That's in msf_dict_survey(). We added those in because of the different tracks for processing survey dictionaries..

@zkamvar
Copy link
Member Author

zkamvar commented Feb 11, 2020

description: "The randomised dataset produced should mimic an excel export from DHIS2 for outbreaks and a Kobo export for surveys".

This makes me realize the description for this is wrong. It should indicate that it produces the dictionaries in an R-friendly manner.

@aspina7
Copy link
Member

aspina7 commented Feb 11, 2020

In the arguments section for diseases - it only lists measles ajs and cholera, but should also specify that for the survey dictionaries the options are mortality, vaccination, nutrition etc...

That's in msf_dict_survey(). We added those in because of the different tracks for processing survey dictionaries..

Yap the help for msf_dict shows both linelist and survey options though - just the arguments section doesnt reflect that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants