Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #8

Merged
merged 11 commits into from
Feb 11, 2020
Merged

Clean up #8

merged 11 commits into from
Feb 11, 2020

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Feb 10, 2020

  • fixed the URLS
  • added vignettes
  • update site, NEWS, and DESCRIPTION
  • fix bug in data generator for survey data where eligible and interviewed fields were not created

You can view the vignettes by installing it:

remotes::install_github("r4epi/epidict#8", dep =TRUE, build_vignettes = TRUE)
browseVignettes("epidict") # this will open your browser (firefox/chrome)

Note that Alex reminded me that we should hold off until the Kobo dictionaries are ready.

@zkamvar zkamvar marked this pull request as ready for review February 11, 2020 11:10
There was an error in the data generation because houshold clusters only
had generated elegible and interviewed for the vaccine template. I've
fixed this and added a test.
@zkamvar zkamvar changed the title CRAN release of 0.1.0 Clean up Feb 11, 2020
@zkamvar
Copy link
Member Author

zkamvar commented Feb 11, 2020

This is no longer about releasing to CRAN since the survey dictionaries need to change.

@zkamvar
Copy link
Member Author

zkamvar commented Feb 11, 2020

This is now a maintenance PR

@zkamvar zkamvar merged commit 8209d5a into master Feb 11, 2020
@zkamvar zkamvar deleted the cran-release-0.1.0 branch February 11, 2020 18:06
@zkamvar zkamvar mentioned this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant