Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release to CRAN needed #35

Open
zkamvar opened this issue Feb 12, 2023 · 1 comment · May be fixed by #36
Open

release to CRAN needed #35

zkamvar opened this issue Feb 12, 2023 · 1 comment · May be fixed by #36

Comments

@zkamvar
Copy link
Member

zkamvar commented Feb 12, 2023

CRAN has been breathing down my neck about epikit and apyramid. Both of these are at risk of being archived (and a big headache for me) if I don't upload them by Tuesday.

Here are some failing checks that were fixed by Hadley a few weeks ago:

Version: 0.1.2
Check: tests
Result: ERROR
     Running ‘testthat.R’ [4s/5s]
    Running the tests in ‘tests/testthat.R’ failed.
    Complete output:
     > library(testthat)
     > library(epikit)
     >
     > test_check("epikit")
     [ FAIL 1 | WARN 1 | SKIP 1 | PASS 111 ]
    
     ══ Skipped tests ═══════════════════════════════════════════════════════════════
     • On CRAN (1)
    
     ══ Failed tests ════════════════════════════════════════════════════════════════
     ── Error ('test-age-categories.R:179'): years alone give years ─────────────────
     Error in `forcats::fct_drop(res, droppings)`: `only` must be a character vector or `NULL`, not a logical vector.
     Backtrace:
     ▆
     1. └─epikit::group_age_categories(df, years = years, one_column = FALSE) at test-age-categories.R:179:2
     2. └─forcats::fct_drop(only = droppings)
     3. └─forcats:::check_character(only, allow_null = TRUE)
     4. └─forcats:::stop_input_type(...)
     5. └─rlang::abort(message, ..., call = call, arg = arg)
    
     [ FAIL 1 | WARN 1 | SKIP 1 | PASS 111 ]
     Error: Test failures
     Execution halted
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/epikit-00check.html), [r-patched-linux-x86_64](https://www.r-project.org/nosvn/R.check/r-patched-linux-x86_64/epikit-00check.html), [r-release-linux-x86_64](https://www.r-project.org/nosvn/R.check/r-release-linux-x86_64/epikit-00check.html)

The last set of checks that worked were from #31, so that's the version I am going to submit.

I am not going to submit the version as it is now with #32 because of two things:

  1. it does not pass checks
  2. it adds another non-CRAN dependency which will make submitting to CRAN even more hellish.
@zkamvar zkamvar linked a pull request Feb 13, 2023 that will close this issue
@aspina7
Copy link
Member

aspina7 commented Feb 13, 2023

mmmm surprised about noncran dependency? Ah fuck because I moved props to epitabulate and that's not submitted....
Right then stick to your plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants