Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Znk fix 233 #238

Merged
merged 6 commits into from
Feb 12, 2020
Merged

Znk fix 233 #238

merged 6 commits into from
Feb 12, 2020

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Feb 11, 2020 •
edited
Loading

This will fix #233, by importing {epikit}. It replaces several functions in sitrep. Additionally:

  • fixed a bug in {epidict} and updated the version imported by sitrep
  • commented out a test about a warning in sitrep that will be addressed in {epibuffet} due to an update to {tidyselect} version 1.0.0

epiamsterdam
epiamsterdam approved these changes Feb 12, 2020
View reviewed changes
Copy link

@epiamsterdam epiamsterdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks

@zkamvar zkamvar removed the request for review from pbkeating February 12, 2020 11:27
@zkamvar zkamvar merged commit 6508940 into master Feb 12, 2020
@zkamvar zkamvar deleted the znk-fix-233 branch February 12, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiamsterdam epiamsterdam epiamsterdam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package for basic counts/proportions and inline styling
2 participants
@zkamvar @epiamsterdam