Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge closely linked charts #81

Open
blootsvoets opened this issue Apr 14, 2021 · 1 comment
Open

Merge closely linked charts #81

blootsvoets opened this issue Apr 14, 2021 · 1 comment

Comments

@blootsvoets
Copy link
Contributor

Charts like radar-upload-backend, -frontend and -connector are so closely linked, they could be represented by a single chart with separate templates for each of the components. See for example https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack with separate template directories per component at https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack/templates.

The values.yaml can still be used to configure each of the services. Other examples:

  • rest-sources-authorizer, -backend
  • radar-upload-backend, -frontend and -connector
  • app-config, -frontend

This makes reuse of values easier and concentrates configuration to where it's needed. Potential disadvantages: some logic may need to be incorporated to override e.g. image tag per subcomponent. However this is not urgent.

@keyvaann
Copy link
Collaborator

Can we include Radar-backend-monitor and -stream too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants