Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate outpoint when transfer multi RGB20 from 1 UTXO #117

Closed
Matrix-Zhang opened this issue Jan 30, 2024 · 5 comments · Fixed by #136
Closed

duplicate outpoint when transfer multi RGB20 from 1 UTXO #117

Matrix-Zhang opened this issue Jan 30, 2024 · 5 comments · Fixed by #136
Assignees
@dr-orlovsky
Labels
question Further information is requested
Milestone
v0.11.0

Comments

@Matrix-Zhang
Copy link

Matrix-Zhang commented Jan 30, 2024 •
edited
Loading

  1. alice tranfer 100 RGB20 to bob
  2. alice tranfer 50 RGB20 to bob

after above steps, bob's one UTXO have 150 RGB20 with two witnesses

  1. bob transfer 100+ (120 eg) to anyone else, it should combined payment

Result: the psbt will have duplicate outpoint ( sparrow will report error)
@dr-orlovsky
Copy link
Member

What do you specifically mean by "PSBT have duplicate outpoint"? Can you provide a Sparrow error text?

@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Feb 8, 2024
@dr-orlovsky dr-orlovsky added the question Further information is requested label Feb 8, 2024
@Matrix-Zhang
Copy link
Author

Matrix-Zhang commented Feb 15, 2024 •
edited
Loading

alice.psbt.zip
the attachment is the psbt
image

@Matrix-Zhang
Copy link
Author

Matrix-Zhang commented Feb 21, 2024 •
edited
Loading

@dr-orlovsky I have try to verify the error, it just demo, if want fix, should modify multiple core codes, I'm can't sure I can correct fix it
image

image

@dr-orlovsky dr-orlovsky moved this to Backlog in RGB release v0.11 Feb 26, 2024
@dr-orlovsky dr-orlovsky mentioned this issue Feb 27, 2024
Closed
@dr-orlovsky
Copy link
Member

More details: BP-WG/bp-wallet#14

dr-orlovsky added a commit that referenced this issue Feb 27, 2024
@dr-orlovsky
pay: fix duplicated inputs
1d067f3 
Closes #117
@dr-orlovsky dr-orlovsky mentioned this issue Feb 27, 2024
Merged
@dr-orlovsky
Copy link
Member

@Matrix-Zhang it ended up that not the outputs are duplicated but inputs (which contain outpoints of the previous transactions, hence the Sparrow message). Please check #136

@dr-orlovsky dr-orlovsky moved this from Backlog to In review in RGB release v0.11 Feb 27, 2024
@dr-orlovsky dr-orlovsky self-assigned this Feb 27, 2024
nicbus pushed a commit to nicbus/rgb that referenced this issue Mar 22, 2024
@dr-orlovsky @nicbus
pay: fix duplicated inputs
1e4c1f9 
Closes RGB-WG#117
@dr-orlovsky dr-orlovsky mentioned this issue Mar 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in RGB release v0.11 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr-orlovsky dr-orlovsky

Labels
question Further information is requested
Projects
RGB release v0.11
Status: Done
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Pay: fix duplicated PSBT inputs RGB-WG/rgb
2 participants
@dr-orlovsky @Matrix-Zhang