From 78a1cacffd35771539ed660bbbea07ad18444784 Mon Sep 17 00:00:00 2001 From: "Robbie.Henderson@avaloq.com" Date: Thu, 21 Dec 2017 13:02:45 +0100 Subject: [PATCH] #22: SCA configuration - fixes - Fix accidental use of StringBuilder(int) constructor Issue: #22 --- .../src/com/avaloq/tools/ddk/check/util/CheckUtil.java | 3 ++- .../tools/ddk/test/ui/junit/runners/TestRunRecording.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/util/CheckUtil.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/util/CheckUtil.java index f065df159..ed18fb97b 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/util/CheckUtil.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/util/CheckUtil.java @@ -36,7 +36,8 @@ public static String toIdentifier(final String source) { } else if (source.length() == 0 || !Character.isJavaIdentifierStart(source.charAt(0))) { return ""; //$NON-NLS-1$ } - StringBuilder result = new StringBuilder(source.charAt(0)); + StringBuilder result = new StringBuilder(); + result.append(source.charAt(0)); boolean space = false; for (Character c : source.substring(1).toCharArray()) { if (Character.isJavaIdentifierPart(c)) { diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java index 44367aebe..b9e058725 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java @@ -440,7 +440,7 @@ private static String getThreadInfo() { boolean contention = THREAD_BEAN.isThreadContentionMonitoringEnabled(); Set deadlockedThreads = getDeadlockThreadIds(); ThreadInfo[] threadInfos = THREAD_BEAN.dumpAllThreads(true, true); - StringBuilder trace = new StringBuilder(threadInfos.length).append(" active threads\r\n"); + StringBuilder trace = new StringBuilder().append(threadInfos.length).append(" active threads\r\n"); for (ThreadInfo info : threadInfos) { if (info == null) { trace.append(" Inactive\r\n");