Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving yml file name from IOin_output_filter to IOin_rhessys_input #12

Open
ryanrbart opened this issue Jul 17, 2021 · 2 comments
Open
Assignees

Comments

@ryanrbart
Copy link
Member

Will,

I am thinking of moving the output filter file name to IOin_rhessys_input. I think this would make the usage more consistent with the other inputs (like the tec file) and would simplify the IOin_output_filter structure.

For example, if an existing output_filter was being used, then a path name in IOin_rhessys_input is all that would be need. If a new output filter is desired, then the path name in IOin_rhessys_input would be specified but an output_filter argument would be added.

Any thoughts or objections?

Ryan

@wburke24
Copy link
Member

yes I think that makes sense, and would get rid of some current replication. Feel free to go ahead with that change if you have a chance, The main thing if you're going to do that is to update the example rmd (vignettes/IOin_examples.rmd) just so there's a clear example usage.

@ryanrbart
Copy link
Member Author

OK, I'm gonna put this on to my todo list. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants