From 261ca337f029d027155486dd91a466486ac0cd9c Mon Sep 17 00:00:00 2001 From: Robert Sun <107655677+rsun19@users.noreply.github.com> Date: Mon, 17 Jun 2024 16:47:37 -0400 Subject: [PATCH 1/2] fixed test for experiments --- .../cypress/cypress/tests/mocked/pipelines/experiments.cy.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/experiments.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/experiments.cy.ts index c1d606d412..1de1d76930 100644 --- a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/experiments.cy.ts +++ b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/experiments.cy.ts @@ -31,11 +31,13 @@ import { RecurringRunStatus, StorageStateKF } from '~/concepts/pipelines/kfTypes const projectName = 'test-project-name'; const initialMockPipeline = buildMockPipelineV2({ display_name: 'Test pipeline' }); +const currentTime = new Date(); +currentTime.setMonth(currentTime.getMonth() - 3); const mockExperiments = [ buildMockExperimentKF({ display_name: 'Test experiment 1', experiment_id: '1', - last_run_created_at: '2024-02-31T15:46:33Z', + last_run_created_at: currentTime.toISOString(), }), buildMockExperimentKF({ display_name: 'Test experiment 2', From 8aec2db8d00c202bb9cb3b4b8adcfe2f5453f2a6 Mon Sep 17 00:00:00 2001 From: Christian Vogt Date: Tue, 18 Jun 2024 11:03:50 -0400 Subject: [PATCH 2/2] add always() condition to upload cypress artifacts --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7809bda71e..a9ed526c12 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -56,6 +56,7 @@ jobs: directory: ./frontend/coverage verbose: true - uses: actions/upload-artifact@v4 + if: ${{ always() }} with: name: cypress-results path: ./frontend/src/__tests__/cypress/results/