Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch upstream main #5

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Fetch upstream main #5

merged 14 commits into from
Aug 26, 2024

Conversation

yzhao583
Copy link
Collaborator

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

ppadti and others added 14 commits August 20, 2024 19:25
…selected (#3101)

* Refactor accelerator profile state hooks to no longer manage its own selected

split init and selected accelerator

feat: Add selected accelerator profile to assemblePodSpecOptions function

* remove comments

* Refactor accelerator profile state hooks to no longer manage its own selected

* feat: Update acceleratorProfile in notebookServer.cy.ts

The `acceleratorProfile` object in `notebookServer.cy.ts` has been modified to include a new property `unknownProfileDetected`. This change ensures that the `acceleratorProfile` state is accurately represented.
@yzhao583 yzhao583 closed this Aug 26, 2024
@yzhao583 yzhao583 reopened this Aug 26, 2024
@yzhao583 yzhao583 merged commit 70467d0 into RHEcosystemAppEng:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.