chore: update deps #783
Merged
chore: update deps #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
force-pushed
the
update-deps
branch
3 times, most recently
from
3b09fc5 to
bbdb792
Compare
Signed-off-by: Lukas Zapletal <[email protected]>
lzap
commented
Mar 11, 2024
| if bi, ok := debug.ReadBuildInfo(); ok { | ||
| for _, dep := range bi.Deps { | ||
| fmt.Printf("updating %s\n", dep.Path) | ||
| cmd := exec.Command(goCmd, "get", "-u", dep.Path) |
There was a problem hiding this comment.
This is marked as a possible problem in Snyk, I believe this is okay for a "helper" script.
There was a problem hiding this comment.
Maybe lets move it to scripts/ as separate go main?
so it's not executable from the production binary and then it's for sure ok.
ezr-ondrej
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates deps.
I had to create a new command within the main binary to be able to easily update deps one by one. Several deps fail to update because Go 1.21 is required. This workrounds this nicely.