Excessive library linking when executables are built

[prckent]

I noticed that the link line for rmg-cpu repeats the library link information many times over. This slows linking and is presumably unintentional. Presumably the cmake dependencies have the wrong target.

Edit: Scroll to see the full line. Notice e.g. -lfftw3 appears many times, as do all the dependencies.

[100%] Linking CXX executable ../rmg-cpu
cd build/RMG && /usr/bin/cmake3 -E cmake_link_script CMakeFiles/rmg-cpu.dir/link.txt --verbose=1
/opt/intel2020/compilers_and_libraries_2020.0.166/linux/bin/intel64/icpc   -std=c++14 -qopenmp  -O3 -DNDEBUG  -rdynamic CMakeFiles/rmg-cpu.dir/Common/Main.cpp.o  -o ../rmg-cpu -Wl,-rpath,/opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib:/opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release: /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpicxx.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread ../InternalPseudo/libInternalPseudo.a -lz -lrt -lm -lrt -lboost_thread -lboost_system -lboost_iostreams -lboost_program_options -lboost_filesystem -lboost_chrono -lboost_date_time -lboost_atomic -lboost_regex /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a ../scalapack/lib/libscalapack.a -Wl,-Bstatic -lfftw3 -lfftw3f -Wl,-Bdynamic -lhdf5 -lsz -lz -ldl -lm ../RmgLib/libRmgLib.a ../Misc/libMisc.a ../XC/libXC.a ../dftd3/libdftd3.a ../MG/libMG.a ../Force/libForce.a ../Input/libInput.a ../Finite_diff/libFinite_diff.a ../US_PP/libUS_PP.a ../zfp/libzfp.a ../spglib/libsymspg_static.a Common/libRMG_Common.a Spin/libRMG_Spin.a Subdiag/libRMG_Subdiag.a ../zfp/libzfp.a ../spglib/libsymspg_static.a ../TDDFT/RMG_TDDFT/libRmgTddft.a ../TDDFT/IO_TDDFT/libIO_Tddft.a ../TDDFT/ELDYN/libeldyn_mod.a ../TDDFT/ELDYN/libEldyn.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpicxx.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread ../InternalPseudo/libInternalPseudo.a -lz -lrt -lm -lrt -lboost_thread -lboost_system -lboost_iostreams -lboost_program_options -lboost_filesystem -lboost_chrono -lboost_date_time -lboost_atomic -lboost_regex /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a ../scalapack/lib/libscalapack.a -Wl,-Bstatic -lfftw3 -lfftw3f -Wl,-Bdynamic -lhdf5 -lsz -lz -ldl -lm ../RmgLib/libRmgLib.a ../Misc/libMisc.a ../XC/libXC.a ../dftd3/libdftd3.a ../MG/libMG.a ../Force/libForce.a ../Input/libInput.a ../Finite_diff/libFinite_diff.a ../US_PP/libUS_PP.a ../zfp/libzfp.a ../spglib/libsymspg_static.a Common/libRMG_Common.a Spin/libRMG_Spin.a Subdiag/libRMG_Subdiag.a ../zfp/libzfp.a ../spglib/libsymspg_static.a ../TDDFT/RMG_TDDFT/libRmgTddft.a ../TDDFT/IO_TDDFT/libIO_Tddft.a ../TDDFT/ELDYN/libeldyn_mod.a ../TDDFT/ELDYN/libEldyn.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpicxx.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread ../InternalPseudo/libInternalPseudo.a -lz -lrt -lm -lrt -lboost_thread -lboost_system -lboost_iostreams -lboost_program_options -lboost_filesystem -lboost_chrono -lboost_date_time -lboost_atomic -lboost_regex /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a ../scalapack/lib/libscalapack.a -Wl,-Bstatic -lfftw3 -lfftw3f -Wl,-Bdynamic -lhdf5 -lsz -lz -ldl -lm ../RmgLib/libRmgLib.a ../Misc/libMisc.a ../XC/libXC.a ../dftd3/libdftd3.a ../MG/libMG.a ../Force/libForce.a ../Input/libInput.a ../Finite_diff/libFinite_diff.a ../US_PP/libUS_PP.a ../zfp/libzfp.a ../spglib/libsymspg_static.a Common/libRMG_Common.a Spin/libRMG_Spin.a Subdiag/libRMG_Subdiag.a ../zfp/libzfp.a ../spglib/libsymspg_static.a ../TDDFT/RMG_TDDFT/libRmgTddft.a ../TDDFT/IO_TDDFT/libIO_Tddft.a ../TDDFT/ELDYN/libeldyn_mod.a ../TDDFT/ELDYN/libEldyn.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpicxx.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/libmpifort.so /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mpi/intel64/lib/release/libmpi.so -ldl -lrt -lpthread ../InternalPseudo/libInternalPseudo.a -lz -lrt -lm -lrt -lboost_thread -lboost_system -lboost_iostreams -lboost_program_options -lboost_filesystem -lboost_chrono -lboost_date_time -lboost_atomic -lboost_regex /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_intel_lp64.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_gnu_thread.a /opt/intel2020/compilers_and_libraries_2020.0.166/linux/mkl/lib/intel64/libmkl_core.a ../scalapack/lib/libscalapack.a -Wl,-Bstatic -lfftw3 -lfftw3f -Wl,-Bdynamic -lhdf5 -lsz -lz -ldl -lm ../RmgLib/libRmgLib.a ../Misc/libMisc.a ../XC/libXC.a ../dftd3/libdftd3.a ../MG/libMG.a ../Force/libForce.a ../Input/libInput.a ../Finite_diff/libFinite_diff.a ../US_PP/libUS_PP.a ../zfp/libzfp.a ../spglib/libsymspg_static.a Common/libRMG_Common.a Spin/libRMG_Spin.a Subdiag/libRMG_Subdiag.a ../zfp/libzfp.a ../spglib/libsymspg_static.a ../TDDFT/RMG_TDDFT/libRmgTddft.a ../TDDFT/IO_TDDFT/libIO_Tddft.a ../TDDFT/ELDYN/libeldyn_mod.a ../TDDFT/ELDYN/libEldyn.a -lifport -lifcoremt -lpthread