Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated on TurtleBot3_Manipulation maintenance #73

Merged
merged 17 commits into from
Dec 2, 2024

Conversation

sunghowoo
Copy link
Contributor

@sunghowoo sunghowoo commented Oct 25, 2024

Improvements:

  1. Added gripper control in teleoperation.
  2. Resolved the issue where teleoperation was not functioning on the actual robot.
  3. Fixed the intermittent issue of Gazebo not launching.
  4. Fixed the error log related to the mimic joint.

@sunghowoo sunghowoo added bug Something isn't working enhancement New feature or request labels Oct 25, 2024
@sunghowoo sunghowoo requested a review from robotpilot October 25, 2024 03:31
Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are EOF errors in multiple places, please double-check each file.

@sunghowoo sunghowoo self-assigned this Oct 29, 2024
Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PYC files should not be included as binaries.
    • base.launch.cpython-310.pyc
    • gazebo.launch.cpython-310.pyc
  • The version of the turtlebot3_manipulation_example package needs to be matched with other packages in the same repository and does not have basic settings such as description and license.
  • Please check the EOF
  • Since all packages are bumped, there should be a changelog for each version.

sunghowoo and others added 6 commits December 2, 2024 19:02
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Pyo <[email protected]>
@robotpilot robotpilot self-requested a review December 2, 2024 23:30
Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robotpilot robotpilot merged commit 7f987a6 into humble-devel Dec 2, 2024
1 check passed
@robotpilot robotpilot deleted the humble-teleop branch December 4, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants