-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated on TurtleBot3_Manipulation maintenance #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are EOF errors in multiple places, please double-check each file.
Signed-off-by: Pyo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- PYC files should not be included as binaries.
- base.launch.cpython-310.pyc
- gazebo.launch.cpython-310.pyc
- The version of the turtlebot3_manipulation_example package needs to be matched with other packages in the same repository and does not have basic settings such as description and license.
- Please check the EOF
- Since all packages are bumped, there should be a changelog for each version.
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Sungho Woo <[email protected]>
Signed-off-by: Pyo <[email protected]>
Signed-off-by: Pyo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improvements: