Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-376] Ignore higher semester admission requirements in the search #12

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Jun 14, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
https://inpsyde.atlassian.net/browse/FAU-376 (erroneously commented in https://inpsyde.atlassian.net/browse/FAU-400)

What is the current behavior? (You can also link to an open issue here)
Degree programs are assigned to different admission requirements taxonomies: Bachelor's/teaching degree and Bachelor's/teaching degree at a higher semester. During filtering, both taxonomies are taken into account, which leads to an issue where the NC column in the list of degree programs displays irrelevant text.

What is the new behavior (if this is a feature change)?
Filtering degree programs is based only on the main Bachelor's/teaching degree taxonomy.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@tyrann0us tyrann0us changed the title [FAU-400] Ignore higher semester admission requirements in the search [FAU-376] Ignore higher semester admission requirements in the search Jun 17, 2024
@tyrann0us tyrann0us closed this Jun 17, 2024
@tyrann0us tyrann0us deleted the FAU-400 branch June 17, 2024 06:38
@tyrann0us
Copy link
Collaborator

Ahh, I'm sorry. GitHub UI said it would update the PR when I rename the branch … 🤦🏽

@tyrann0us tyrann0us restored the FAU-400 branch June 17, 2024 06:40
@tyrann0us tyrann0us reopened this Jun 17, 2024
Copy link
Collaborator

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@zhyian zhyian merged commit c171c04 into dev Jun 17, 2024
16 checks passed
@zhyian zhyian deleted the FAU-400 branch June 17, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants