Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-402] Introduce editableOnly method for admin-only taxonomy visibility and editing #19

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-402

What is the new behavior (if this is a feature change)?
This PR introduces a new method editableOnly. The purpose of this method is to allow taxonomy terms to be managed in the WordPress admin dashboard while disabling their single term view on the front end.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Does our term selector work as expected?

@zhyian
Copy link
Collaborator Author

zhyian commented Dec 18, 2024

Does our term selector work as expected?

Yes, everything works as it should.

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@zhyian zhyian merged commit 46e5105 into main Dec 24, 2024
8 checks passed
@zhyian zhyian deleted the FAU-402 branch December 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants