Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-420] Add new "German language skills for international students" filter and allow sorting by it #5

Merged
merged 2 commits into from
May 10, 2024

Conversation

amiut
Copy link
Collaborator

@amiut amiut commented May 8, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-420
No filter for required German language skills for degree programs

What is the new behavior (if this is a feature change)?

  • Added new "German language skills for international students" filter
  • Make "German language skills for international students" as sortable

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Main PR: RRZE-Webteam/FAU-Studium-Embed#29

@amiut amiut changed the title [FAU-420] Add new "German language skills for international students" filter [FAU-420] Add new "German language skills for international students" filter and allow sorting by it May 8, 2024
@amiut amiut marked this pull request as ready for review May 8, 2024 12:40
@amiut amiut requested review from shvlv, tyrann0us, zhyian and o-samaras May 8, 2024 12:40
Copy link
Collaborator

@zhyian zhyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@amiut amiut merged commit 58c96a8 into dev May 10, 2024
8 checks passed
@amiut amiut deleted the FAU-420 branch May 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants