Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-376] Synchronize child terms for degree and admission requirement taxonomies #39

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Jul 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-376

What is the new behavior (if this is a feature change)?
Child terms are synchronized for the Degree and Admission Requirement taxonomies. Additionally, slugs for the Admission Requirement taxonomies are updated to support the pre-filtered feature.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Psaml issues should be fixed after merge RRZE-Webteam/FAU-Studium-Common#15

…xonomies; sync slugs for admission requirement taxonomies
@zhyian zhyian marked this pull request as ready for review July 12, 2024 19:26
@zhyian zhyian requested review from shvlv, amiut and o-samaras July 12, 2024 19:26
Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, Thanks a lot 💪
Code LGTM and works as expected

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/Infrastructure/Search/FilterableTermsUpdater.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

src/Infrastructure/Search/TermData.php Outdated Show resolved Hide resolved
@zhyian zhyian merged commit 408c64b into dev Jul 16, 2024
6 checks passed
@zhyian zhyian deleted the FAU-376 branch July 16, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants