Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-443] Synchronize parent and child terms using the MultilingualLink representation #49

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-443

What is the new behavior (if this is a feature change)?
Added synchronization for 'German language skills for international students' child terms to consuming websites. This update likely extends to all taxonomies where terms are represented as MultilingualLink.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Related PR that introduces a parent in MultilingualLink property: RRZE-Webteam/FAU-Studium-Common#20

The Psalm issues should be resolved once the above PR is merged.

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/Infrastructure/Search/FilterableTermsUpdater.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks ✌️

@zhyian zhyian requested a review from amiut January 2, 2025 09:56
@zhyian zhyian merged commit 2e75864 into dev Jan 3, 2025
7 checks passed
@zhyian zhyian deleted the FAU-443 branch January 3, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants