Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-443] Synchronize parent and child terms using the MultilingualLink representation #49

Merged
merged 5 commits into from
Jan 3, 2025
Merged

[FAU-443] Synchronize parent and child terms using the MultilingualLink representation #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4785b32
feat: synchronize parent and child terms using the MultilingualLink r…
zhyian Dec 24, 2024
5f69153
doc: update CHANGELOG.md
zhyian Dec 24, 2024
8ab3704
refactor: simplify code
zhyian Dec 26, 2024
d5790ad
Merge branch 'dev' into FAU-443
zhyian Dec 26, 2024
73ca3fd
chore: update common package
zhyian Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add synchronization of 'German language skills for international students' child terms to consuming websites.

### Changed

- Keywords are indexed for searching.
Expand Down
8 changes: 4 additions & 4 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Infrastructure/Search/FilterableTermsUpdater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ private function retrieveParentTermId(
return 0;
}

/** @var AdmissionRequirement|Degree $flatProperty */
/** @var AdmissionRequirement|Degree|MultilingualLink $flatProperty */
$parentProperty = $flatProperty->parent();

if (is_null($parentProperty)) {
Expand Down Expand Up @@ -403,7 +403,7 @@ private function isHierarchicalProperty(
MultilingualString|MultilingualLink|AdmissionRequirement|Degree $flatProperty
): bool {

return $flatProperty instanceof Degree || $flatProperty instanceof AdmissionRequirement;
return !$flatProperty instanceof MultilingualString;
}

private function createTerm(TermData $termData): ?int
Expand Down
Loading