Skip to content

Commit

Permalink
fix: include admission requirement slug in degree program data on edi…
Browse files Browse the repository at this point in the history
…tor form
  • Loading branch information
zhyian committed Jul 17, 2024
1 parent 3de0042 commit 14e9c0f
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 1 deletion.
4 changes: 3 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
"scripts": {
"check-coding-standards": "@php ./vendor/squizlabs/php_codesniffer/bin/phpcs",
"check-psalm": "@php ./vendor/vimeo/psalm/psalm --output-format=compact --no-cache",
"fix-coding-standards": "@php ./vendor/squizlabs/php_codesniffer/bin/phpcbf"
"fix-coding-standards": "@php ./vendor/squizlabs/php_codesniffer/bin/phpcbf",
"tests": "@php ./vendor/phpunit/phpunit/phpunit --coverage-text",
"tests:no-cov": "@php ./vendor/phpunit/phpunit/phpunit --no-coverage"
}
}
1 change: 1 addition & 0 deletions resources/ts/defs/degree-program-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,5 @@ export interface DegreeProgramPost extends Post {

export interface AdmissionRequirement extends MultilingualLink {
parent: AdmissionRequirement | null;
slug: string;
}
2 changes: 2 additions & 0 deletions resources/ts/util/transforms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ export function transformTermToAdmissionRequirement(
term
) as AdmissionRequirement;

admissionRequirement.slug = term?.slug ?? '';

if ( ! term ) {
return admissionRequirement;
}
Expand Down
1 change: 1 addition & 0 deletions src/Infrastructure/Repository/TermsRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public function admissionRequirement(?WP_Term $term): AdmissionRequirement
return AdmissionRequirement::new(
$this->bilingualLinkFromTerm($term),
$parent instanceof WP_Term ? $this->admissionRequirement($parent) : null,
$term->slug
);
}
}
2 changes: 2 additions & 0 deletions tests/js/__mocks__/admission-requirements.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const mockFreiAdmissionRequirement: DegreeProgramData['admission_requirem
en: 'frei',
},
parent: null,
slug: 'frei'
};

export const mockAbcAdmissionRequirement: DegreeProgramData['admission_requirements']['bachelor_or_teaching_degree'] =
Expand All @@ -40,4 +41,5 @@ export const mockAbcAdmissionRequirement: DegreeProgramData['admission_requireme
en: 'abc',
},
parent: null,
slug: 'abc'
};

0 comments on commit 14e9c0f

Please sign in to comment.