Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed klayout tech files and DRC deck #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed klayout tech files and DRC deck #304

wants to merge 2 commits into from

Conversation

marwaneltoukhy
Copy link
Collaborator

Added correct tech files for klayout
Added DRC deck that is used in precheck to tapeout caravel

RTimothyEdwards
RTimothyEdwards requested changes Nov 2, 2022
View reviewed changes
Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm already installing the sky130_mr.drc file from precheck, so that it's not necessary to maintain a redundant copy of the file in open_pdks. Are you using the file installed in, e.g., libs.tech/klayout/drc/sky130A_mr.drc?

RTimothyEdwards
RTimothyEdwards reviewed Nov 2, 2022
View reviewed changes
Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus your changes to the sky130.lyp file look like the changes that are already in, e.g., libs.tech/klayout/tech/sky130A.lyp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTimothyEdwards RTimothyEdwards RTimothyEdwards requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marwaneltoukhy @RTimothyEdwards