Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Presentations using templates from the same region are always collapsed into a single region #26

Open
willprice76 opened this issue Jul 25, 2016 · 11 comments

Comments

@willprice76
Copy link
Contributor

If I have a page with the following CPS:

Teaser (2-column)
Teaser (2-column)
Article
Teaser (2-column)
Teaser (2-column)

When the page is rendered, the 2 groups of 2-col teasers will be collapsed into a single 2-col region, whereas what I expected, as an editor is for the article to appear between two separate 2-col regions.

@rpannekoek
Copy link
Contributor

If you want to have two Regions which use the 2-Column Region View, you should ensure that you define two Regions with distinct names. For that purpose, we introduced a Region Name metadata field next to Region View Name in DXA 1.2.

@willprice76
Copy link
Contributor Author

This sounds like I would need to duplicate all my component templates - so not an ideal solution - or do I misunderstand?

@rpannekoek
Copy link
Contributor

rpannekoek commented Jul 25, 2016

No, that's correct; you will need to have CTs for each distinct Region; the CTs don't represent much more than the MVC metadata. In general, the currently solution of using CT metadata to indicate Region is not ideal, but a necessary evil until we get full Region support in SDL Web itself (which might happen this year :-))

@willprice76
Copy link
Contributor Author

I created a PR with what I think is a better solution. #27

@bb-ceccles
Copy link

Second this as an improvement. Would be a big improvement if this functionality was enabled

@ablyth-building-blocks
Copy link

+1

2 similar comments
@AndyMcInnes
Copy link

+1

@rsleggett
Copy link

+1

@Vouzamo
Copy link

Vouzamo commented Aug 12, 2016

+1 (component presentation metadata would be the best solution)

@rpannekoek
Copy link
Contributor

TSI-1945 (internal issue ID for tracking purposes)

@justsayantan
Copy link

+1

@rpannekoek rpannekoek added this to the v2.2 milestone Dec 18, 2018
@rpannekoek rpannekoek added the PR label Dec 18, 2018
@rpannekoek rpannekoek removed this from the v2.2 milestone May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants