Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryFileManager - StripDimensions UrlDecode ran only when no dimensions #84

Open
bb-ceccles opened this issue May 4, 2021 · 1 comment

Comments

@bb-ceccles
Copy link

When an image has spaces or special characters there is a difference in how the image handler is working depending on if the image does or doesn't have the image resizing parameters added.

Looking in to the code base the StripDimensions method within the BinaryFileManager does the following

// TSI-417: unescape and only escape spaces path = WebUtility.UrlDecode(path); path = path.Replace(" ", "%20");

But this is only ran when there are not any dimensions. If there are dimensions the path is returned before this is ran.

@bb-ceccles
Copy link
Author

Added a PR for the code change needed for this.

#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant