Allow whitelisting some websites

[martin-braun]

There are cases where Undisposition is not useful. For instance when downloading a certificate from Apple's Certificate, Identifiers & Profiles. This is just one case. Some websites fail to provide the right headers so this extension can't work out what is binary or not, thus attempting to show binary data as text or naming the filename wrong.

In case of Apples certificate website, it names the *.cer file "downloadCertificateContent.action", which is wrong.

Being able to white list critical websites would give more control to the user.

[nihaals]

Another example of a site that stops working is Google Drive

[Racle]

I'll look into this andI do not promise any time frame for this.

And If/when I get this done, this feature is coming as right click menu option as I do want to keep extension icon as fast toggle.

Currently extension is checking URL and getting extension from that (very simple solution).
If that extension finds commonly used extensions, it has checks for those.

[martin-braun]

@Racle Thanks, yes, you don't have to provide any ETA, I'm thankful for this extension nonetheless. Often I can simply press CMD+S to store the file anyway. In case of wrong filenames, I can also just rename the file to what it should supposed to be. However, a few times I fell in this pitfall, because I forgot.

I agree that a context menu implementation is enough. A dev who discovers problems will attempt to try to right click to find a white list feature anyway.

Thanks for your fork.

[nihaals]

Having a default blacklist could be helpful in instances where downloading just doesn't work. For example, with Google Drive, you get an error about third party cookies not being enabled and there is no other way to download the file. Since the error message is wrong, it will likely lead to people looking into different solutions without thinking this was the cause.

[orschiro]

Same issue for me.

It sadly breaks Google Drive download.

Doesn't happen if I disable the extension.

[Racle]

@martin-braun @nihaals @orschiro
Just uploaded version 0.0.5 with (very simple) blacklist to Firefox and Chrome web stores.
You can find Settings by right clicking extension icon.

This should be approved soon.

Chrome version also has manifest v3 support, so that should work even after that is forced.

[orschiro]

Nice, thank you!

…

On Sun, 23 Oct 2022 at 18:45, Ville Viitaharju ***@***.***> wrote: @martin-braun <https://github.com/martin-braun> @nihaals <https://github.com/nihaals> @orschiro <https://github.com/orschiro> Just uploaded version 0.0.5 with (very simple) blacklist to Firefox and Chrome web stores. You can find Settings by right clicking extension icon. This should be approved soon. Chrome version also has manifest v3 support, so that should work even after that is forced. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABJXQ5VO4H6KJYJVSZO6HTWEVTTVANCNFSM5D6ADDQA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nihaals]

I'm not sure if Manifest v3 supports it, but it would be nice to be able to use the browser's built-in settings button too (options_page/options_ui) to stay consistent with other extensions.

[nihaals]

Created as #4

[martin-braun]

@Racle Should we maintain a proper default black list? I see apple.com and google.com made it, but dropbox.com and potentially more websites are affected, especially those that offer a preview of the file by default.

[orschiro]

Or maybe also interesting to have a whitelist feature? Meaning disable always except for those whitelisted pages. In my case, I have only one site where I need it and the rest of the time I want it to be disabled to prevent issues.

…

On Wed, 9 Nov 2022, 12:42 Martin Braun, ***@***.***> wrote: @Racle <https://github.com/Racle> Should we maintain a proper default black list? I see apple.com and google.com made it, but dropbox.com and potentially more websites are affected, especially those that offer a preview of the file by default. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABJXQ6LIKP6RIFDAOR6UCDWHOEZZANCNFSM5D6ADDQA> . You are receiving this because you were mentioned.Message ID: ***@***.***>