Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced font color for components heading in dark mode #822

Merged
merged 16 commits into from
Jun 6, 2024

Conversation

KARTHIK174
Copy link
Contributor

@KARTHIK174 KARTHIK174 commented May 30, 2024

Fixes Issue🛠️

Closes #650

Description👨‍💻

Changed the font colors for the components accordingly and also changed the hover color for footer social media icons to red color which suits for the navigation bar color when clicked.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot 2024-05-30 104710

Changed the font colours for the components accordingly and also changed the hover color for footer social media icons to red colour which suits for the navigation bar color when clicked.
Copy link

netlify bot commented May 30, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit cfe9658
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/66620f405036e30008535dbd
😎 Deploy Preview https://deploy-preview-822--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KARTHIK174, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100 Rakesh9100 changed the title Enhanced font color for components Enhanced font color for components heading in dark mode May 30, 2024
@Rakesh9100
Copy link
Owner

Make the heading color changes only for the dark mode, no changes to the light theme @KARTHIK174

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 30, 2024
when we toggle from light to dark theme then the font colour changes according to the theme we selected.
Copy link
Contributor Author

@KARTHIK174 KARTHIK174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we toggle from light to dark theme then the font colour changes according to the theme we selected.
Screenshot 2024-05-31 154940
Screenshot 2024-05-31 154958

@Rakesh9100 Rakesh9100 merged commit 41b495e into Rakesh9100:main Jun 6, 2024
4 checks passed
Copy link

github-actions bot commented Jun 6, 2024

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @KARTHIK174

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points and removed question 🤔 Further information is requested labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Enhance font color for components heading in dark mode
2 participants