diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml new file mode 100644 index 0000000..9cbf9bd --- /dev/null +++ b/.github/workflows/clippy.yml @@ -0,0 +1,14 @@ +on: push +name: Clippy check + +# Make sure CI fails on all warnings, including Clippy lints +env: + RUSTFLAGS: "-Dwarnings" + +jobs: + clippy_check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Run Clippy + run: cargo clippy --all-targets --all-features diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml new file mode 100644 index 0000000..d727d69 --- /dev/null +++ b/.github/workflows/fmt.yml @@ -0,0 +1,18 @@ +on: pull_request + +name: Rustfmt + +jobs: + format: + runs-on: ubuntu-latest + permissions: + pull-requests: write + steps: + - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@nightly + with: + components: rustfmt + - uses: mbrobbel/rustfmt-check@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + mode: review \ No newline at end of file diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 066d75d..e69de29 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -1,38 +0,0 @@ -name: SonarCloud analysis - -on: - push: - branches: [ "master" ] - pull_request: - branches: [ "master" ] - workflow_dispatch: - -permissions: - pull-requests: read # allows SonarCloud to decorate PRs with analysis results - -jobs: - Analysis: - runs-on: ubuntu-latest - - steps: - - name: Analyze with SonarCloud - - # You can pin the exact commit or the version. - # uses: SonarSource/sonarcloud-github-action@de2e56b42aa84d0b1c5b622644ac17e505c9a049 - uses: sonarsource/sonarcloud-github-action@master - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Generate a token on Sonarcloud.io, add it to the secrets of this repo with the name SONAR_TOKEN (Settings > Secrets > Actions > add new repository secret) - with: - # Additional arguments for the sonarcloud scanner - args: - # Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu) - # mandatory - -Dsonar.projectKey=RakuJa_BYBE - -Dsonar.organization=rakuja - #-Dsonar.projectBaseDir=app - # Comma-separated paths to directories containing main source files. - #-Dsonar.sources= # optional, default is project base directory - #-Dsonar.tests= # optional. For more info about Code Coverage, please refer to https://docs.sonarcloud.io/enriching/test-coverage/overview/ - # Adds more detail to both client and server-side analysis logs, activating DEBUG mode for the scanner, and adding client-side environment variables and system properties to the server-side log of analysis report processing. - #-Dsonar.verbose= # optional, default is false diff --git a/Cargo.toml b/Cargo.toml index d272d60..62352c2 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -14,7 +14,6 @@ validator = {version="0.16.1", features = ["derive"]} utoipa = { version = "4", features = ["actix_extras"] } utoipa-swagger-ui = { version = "4", features = ["actix-web"] } -redis = {version = "0.23.0-beta.1", features = ["json"]} sqlx = { version = "0.7.2", features = ["runtime-async-std", "sqlite"] } mini-moka = "0.10.2" diff --git a/src/db/db_communicator.rs b/src/db/db_communicator.rs index ba8c756..7437159 100644 --- a/src/db/db_communicator.rs +++ b/src/db/db_communicator.rs @@ -84,7 +84,7 @@ async fn from_raw_to_creature(conn: &Pool, raw: &RawCreature) -> Creatur } pub async fn fetch_creatures(conn: &Pool) -> Result, Error> { - let creatures = sqlx::query_as::<_, RawCreature>("SELECT * FROM CREATURE_TABLE") + let creatures = sqlx::query_as::<_, RawCreature>("SELECT * FROM CREATURE_TABLE ORDER BY name") .fetch_all(conn) .await; match creatures {