Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw-window-handle requirement from 0.5.0 to 0.6.0 #313

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Updates the requirements on raw-window-handle to permit the latest version.

Release notes

Sourced from raw-window-handle's releases.

v0.6.0

  • Breaking: Raw pointer handles now use NonNull where appropriate, to avoid null pointer dereferences.
  • Breaking: Renamed empty methods to new, and take parameters in most of those, to better match normal Rust semantics.
  • Breaking: HasRaw(Display/Window)Handle::raw_(display/window)_handle returns a result indicating if fetching the window handle failed (#122).
  • Breaking: Remove the Active/ActiveHandle types from the public API (#126).
  • Breaking: Remove AppKitWindowHandle::ns_window and UiKitWindowHandle::ui_window since they can be retrieved from the view (#129).
  • Breaking: Remove Copy derive from RawWindowHandle and WindowHandle (#140).
  • Implement PartialEq, Eq and Hash for WindowHandle too. (#128)
  • Implement the relevant traits for &mut T where T: <trait>. (#130)
  • Add web handles for wasm-bindgen v0.2. They are locked behind the wasm-bindgen-0-2 feature. (#134)
  • Deprecate the raw window/display handle traits. They will be removed at the next stable release. (#139)
Changelog

Sourced from raw-window-handle's changelog.

0.6.0 (2023-09-30)

  • Breaking: Raw pointer handles now use NonNull where appropriate, to avoid null pointer dereferences.
  • Breaking: Renamed empty methods to new, and take parameters in most of those, to better match normal Rust semantics.
  • Breaking: HasRaw(Display/Window)Handle::raw_(display/window)_handle returns a result indicating if fetching the window handle failed (#122).
  • Breaking: Remove the Active/ActiveHandle types from the public API (#126).
  • Breaking: Remove AppKitWindowHandle::ns_window and UiKitWindowHandle::ui_window since they can be retrieved from the view (#129).
  • Breaking: Remove Copy derive from RawWindowHandle and WindowHandle (#140).
  • Implement PartialEq, Eq and Hash for WindowHandle too. (#128)
  • Implement the relevant traits for &mut T where T: <trait>. (#130)
  • Add web handles for wasm-bindgen v0.2. They are locked behind the wasm-bindgen-0-2 feature. (#134)
  • Deprecate the raw window/display handle traits. They will be removed at the next stable release. (#139)

0.5.2 (2023-03-31)

  • Add several types for using raw window handles safely, including HasWindowHandle, WindowHandle, HasDisplayHandle, DisplayHandle and Active (#110).

0.5.1 (2023-03-07)

  • Add the rust-version field (1.64).
  • Implemented From for RawWindowHandle and RawDisplayHandle

0.5.0 (2022-07-14)

  • Breaking: The RawWindowHandle variants were split into RawDisplayHandle and RawWindowHandle.
  • The X11 screen is now present in new XlibDisplayHandle and XcbDisplayHandle.
  • Add GBM support.

0.4.3 (2022-03-29)

0.4.2 (2021-11-24)

  • Also implement HasRawWindowHandle for Rc<T>, and Arc<T> where T: ?Sized.

0.4.1 (2021-11-19)

  • Added an impl of HasRawWindowHandle for &T, Rc<T>, and Arc<T>. The impls for Rc<T> and Arc<T> require the alloc feature.

0.4.0 (2021-11-15)

  • Breaking: Remove _do_not_use tags to use #[non_exhaustive] macro
  • Breaking: RawWindowHandle variants are no longer cfg-guarded by platform.
  • Breaking: Rename IOS to UiKit.
  • Breaking: Rename MacOS to AppKit.
  • Breaking: Rename Windows to Win32.
  • Breaking: Rename Redox to Orbital.

... (truncated)

Commits
  • 2c2aaa9 final changelog date.
  • af04e3b v0.6.0 (#132)
  • e3f68a7 breaking: Deprecate the HasRaw*Handle traits
  • 809b130 Add wasm-bindgen v0.2 handles for web_sys::HtmlCanvasElement and web_sys::Off...
  • 69d9eac Change how handles are constructed, so that we can ensure non-null handles (#...
  • 4611ee8 breaking: Remove Copy for RawWindowHandle/WindowHandle
  • 880b305 Remove window handles from Apple handles (#129)
  • 64d2269 Implement traits for &mut T (#133)
  • e3d2e69 Incorrect changelog PR number (#130)
  • 59d3ad2 m: Make sure traits are uniform across WindowHandle and DisplayHandle
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [raw-window-handle](https://github.com/rust-windowing/raw-window-handle) to permit the latest version.
- [Release notes](https://github.com/rust-windowing/raw-window-handle/releases)
- [Changelog](https://github.com/rust-windowing/raw-window-handle/blob/master/CHANGELOG.md)
- [Commits](rust-windowing/raw-window-handle@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: raw-window-handle
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 2, 2023
@patowen
Copy link
Collaborator

patowen commented Nov 18, 2023

I don't think this will be possible until ash-window is updated to support this version of raw-window-handle.

It looks like this is currently a work in progress: ash-rs/ash#799

@patowen
Copy link
Collaborator

patowen commented Feb 24, 2024

As far as I can tell, there's no way to tell Dependabot to ignore a package until a different package has updated to a newer major version. Because of that, these PRs will unfortunately be in a weird state where leaving them open or closing them is not ideal.

Ideally, we'd just be able to say "ignore raw-window-handle updates until ash-window is on version 0.13". That being said, since ash-window will require a new version of raw-window-handle, the right answer might simply be to tell dependabot to ignore this version (or potentially all major version updates for raw-window-handle, since it can just report ash-window instead).

@Ralith
Copy link
Owner

Ralith commented Feb 24, 2024

Ignoring RWH categorically makes sense, since it's purely an interop crate.

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 26, 2024

Looks like raw-window-handle is no longer being updated by Dependabot, so this is no longer needed.

@dependabot dependabot bot closed this Mar 26, 2024
@dependabot dependabot bot deleted the dependabot/cargo/raw-window-handle-0.6.0 branch March 26, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants