Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Lot of General UI Questions #109

Open
cyyeung1234 opened this issue Aug 23, 2021 · 1 comment
Open

A Lot of General UI Questions #109

cyyeung1234 opened this issue Aug 23, 2021 · 1 comment

Comments

@cyyeung1234
Copy link

cyyeung1234 commented Aug 23, 2021

First off, I want to share my appreciation for the author's work. I think something truly groundbreaking is done here in this work.

However, I think overall the github and readme could use significant documentation improvement. Having successfully followed the setup instructions and played with the UI. I have several questions and comments.

  1. What is the difference between main.py and main_attribute.py? This is not explained.
  2. What is the purpose of the right image panel in main_attribute.py?
  3. It looks like 4 buttons and icons do not do anything (add_new_document.png, open.png, paint_can.png, undo.png). It looks like only foot2.png and reset1.png are configured. Noting this in the readme would be helpful to others.
  4. Are the selectable distribution of images (on UI start) real or generated? Do the location of the dots have any significance?
  5. The paper mentions being able to do attribute-conditioned sampling. Any recommendations on how to perform this, even without the UI?
  6. As others have noted, it looks like a tutorial needs to be added for photo opening. I've seen several YouTube videos with the Elon Musk example: https://www.youtube.com/embed/Lt4Z5oOAeEY. None of the default "dots" include the Elon Musk photo, so this must be an example of photo opening and real-photo editing. It would be great if a link to this example was provided, or if the updated tutorial included this demonstration!
@marcelpadilla
Copy link

I really want to know how to add an image myself! I got it running on windows 10 but the buttons on the left don't help me like you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants