Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type check, typescript ensures there are numbers #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove type check, typescript ensures there are numbers #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
268a32a
Remove type check, typescript ensures there are numbers
rogersm May 16, 2021
5ec375c
Merge branch 'Ranvier-TS:master' into master
rogersm May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/Attribute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,6 @@ export class Attribute {
formula: AttributeFormula | null,
metadata: Metadata
) {
if (isNaN(base)) {
throw new TypeError(`Base attribute must be a number, got ${base}.`);
}
if (isNaN(delta)) {
throw new TypeError(`Attribute delta must be a number, got ${delta}.`);
}
if (formula && !(formula instanceof AttributeFormula)) {
throw new TypeError(
'Attribute formula must be instance of AttributeFormula'
Expand Down