-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-1293: Update rasa-calm-demo to version 3.10.1 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update some e2e_tests to the new assertions format * adapt 2 correction test cases * adapt all cancellations, chitchat, disambiguation * adapt test cases in invalid_path, invalid_user_inputs, negations, potential_bugs * adapt digressions, flow_guards, skip_question * adapt tests for corrections * adapt all happy_path test cases * fix error in running datetime validation in the custom actions * add generative assertion test cases * update gitignore * Add assertions for failing and flaky tests * udate rasa-pro to 3.10.0rc1 * add mlflow optional dependency, add new workflow and new make commands * fix CI deprecation warning, fix failing test case * update threshold to prevent flakiness * update button payload and test case * fix flaky passing e2e test --------- Co-authored-by: Maksim Moiseikin <[email protected]>
* add some updated existing tests in a separate folder, add a new CI workflow and make command * add chitchat generative assertions test case * update to rasa pro 3.10.0rc2 * set assertion_order_enabled to true in 1 test step
This will fix a TypeError when we get a string like "50 dollars"
…oney Replace hardcoded currency strings with a regex parsing [ENG-1303]
Update rasa-pro to 3.10.0rc3
* link to add_contact in pattern_clarification * link from check_portfolio to pattern_human_handoff * link from pattern_clarification to pattern_human_handoff * do not rephrase utter_human_handoff_not_available * ENG-1293: Added pattern_human_handoff flow * ENG-1293: Running tests with `--e2e-results`, and saving results on failure, to assist in troubleshooting * ENG-1293: Update `rasa-calm-demo` to version 3.10.1 * ENG-1293: Fix 2 failing tests Remove `utter_clarification_options_rasa` assertion in the following two failing tests, as now this step won't be reached: 1. e2e_tests_with_assertions/passing/disambiguation/user_sends_short_verb_only_message.yml::user sends short verb only message 2. e2e_tests_with_assertions/passing/negations/users_says_they_dont_want_the_former_option.yml::user says they don't want the former option * ENG-1293: fix mistake, had removed assertion from a wrong similar sounding test, corrected it now * ENG-1293: fix/update test `user_sends_short_verb_only_message`, based on recent pattern-clarification changes * ENG-1293: properly add `pattern_human_handoff` to default `pattern_clarification` * ENG-1293: Add tests to verify that link to `pattern_human_handoff` is triggered in relevant conditions On these conditions: 1. When `pattern_clarification` is triggered twice 2. Or when login fails during check-portfolio at least 3 times --------- Co-authored-by: Tanja Bunk <[email protected]>
djcowley
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Making the assumption that changes have been reviewed prior to merging into release-3.10
Tawakalt
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
rasa-calm-demo
'smain
branch to version3.10.1
, now that PR #57 is included in this branchrelease-3.10
.TODOs