From cc832634851a244b78b738af4543b073611ac175 Mon Sep 17 00:00:00 2001 From: Tobias Wochinger Date: Fri, 20 Nov 2020 14:01:22 +0100 Subject: [PATCH 1/6] introduce linter error --- rasa_sdk/endpoint.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rasa_sdk/endpoint.py b/rasa_sdk/endpoint.py index ece7b3f66..ac36f0917 100644 --- a/rasa_sdk/endpoint.py +++ b/rasa_sdk/endpoint.py @@ -56,6 +56,10 @@ def create_argument_parser(): return parser +def function_without_docstring(): + print("I don't have a docstring") + + def create_app( action_package_name: Union[Text, types.ModuleType], cors_origins: Union[Text, List[Text], None] = "*", From 0828284548297d0dbcfdb58f1bb07f6d8b7c1e8e Mon Sep 17 00:00:00 2001 From: Tobias Wochinger Date: Fri, 20 Nov 2020 14:02:04 +0100 Subject: [PATCH 2/6] use `ref` instead of `head_ref` --- .github/workflows/continous-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/continous-integration.yml b/.github/workflows/continous-integration.yml index 3abb01bea..17b0ee995 100644 --- a/.github/workflows/continous-integration.yml +++ b/.github/workflows/continous-integration.yml @@ -64,7 +64,7 @@ jobs: # Fetch entire history for current branch so that `make lint-docstrings` # can calculate the proper diff between the branches - git pull --ff-only --unshallow origin "${{ github.head_ref }}" + git pull --ff-only --unshallow origin "${{ github.ref }}" - name: Lint Code 🎎 run: | From 41cf9aa11b7c23ca12bab74cf34fbfb629ff323d Mon Sep 17 00:00:00 2001 From: Tobias Wochinger Date: Fri, 20 Nov 2020 14:06:10 +0100 Subject: [PATCH 3/6] Revert "introduce linter error" This reverts commit cc832634851a244b78b738af4543b073611ac175. --- rasa_sdk/endpoint.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/rasa_sdk/endpoint.py b/rasa_sdk/endpoint.py index ac36f0917..ece7b3f66 100644 --- a/rasa_sdk/endpoint.py +++ b/rasa_sdk/endpoint.py @@ -56,10 +56,6 @@ def create_argument_parser(): return parser -def function_without_docstring(): - print("I don't have a docstring") - - def create_app( action_package_name: Union[Text, types.ModuleType], cors_origins: Union[Text, List[Text], None] = "*", From b4bdf3695ef69e393961901c38d0f634c3c63154 Mon Sep 17 00:00:00 2001 From: Tobias Wochinger Date: Fri, 20 Nov 2020 14:10:51 +0100 Subject: [PATCH 4/6] use git fetch --- .github/workflows/continous-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/continous-integration.yml b/.github/workflows/continous-integration.yml index 17b0ee995..20e44c1e1 100644 --- a/.github/workflows/continous-integration.yml +++ b/.github/workflows/continous-integration.yml @@ -64,7 +64,7 @@ jobs: # Fetch entire history for current branch so that `make lint-docstrings` # can calculate the proper diff between the branches - git pull --ff-only --unshallow origin "${{ github.ref }}" + git fetch --unshallow origin "${{ github.ref }}" - name: Lint Code 🎎 run: | From bf2692ea21d3ea272fc32f2e36888fecfb511763 Mon Sep 17 00:00:00 2001 From: Tobias Wochinger Date: Fri, 20 Nov 2020 14:13:32 +0100 Subject: [PATCH 5/6] introduce docstring error --- rasa_sdk/endpoint.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rasa_sdk/endpoint.py b/rasa_sdk/endpoint.py index ece7b3f66..03f49902c 100644 --- a/rasa_sdk/endpoint.py +++ b/rasa_sdk/endpoint.py @@ -55,6 +55,8 @@ def create_argument_parser(): utils.add_logging_option_arguments(parser) return parser +def test_without_docstring(): + print("bla") def create_app( action_package_name: Union[Text, types.ModuleType], From cbbe6b50a58aa176761d6b5a3d33ea0bac01ba6a Mon Sep 17 00:00:00 2001 From: Tobias Wochinger Date: Fri, 20 Nov 2020 14:15:32 +0100 Subject: [PATCH 6/6] Revert "introduce docstring error" This reverts commit bf2692ea21d3ea272fc32f2e36888fecfb511763. --- rasa_sdk/endpoint.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/rasa_sdk/endpoint.py b/rasa_sdk/endpoint.py index 03f49902c..ece7b3f66 100644 --- a/rasa_sdk/endpoint.py +++ b/rasa_sdk/endpoint.py @@ -55,8 +55,6 @@ def create_argument_parser(): utils.add_logging_option_arguments(parser) return parser -def test_without_docstring(): - print("bla") def create_app( action_package_name: Union[Text, types.ModuleType],