Skip to content

Commit

Permalink
drop python 3.8 support
Browse files Browse the repository at this point in the history
  • Loading branch information
vcidst committed Oct 22, 2024
1 parent abd0fc6 commit f75c644
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
python-version: [3.8, 3.9, '3.10', '3.11', '3.12']
python-version: [3.9, '3.10', '3.11', '3.12']

steps:
- name: Checkout git repository 🕝
Expand Down
4 changes: 2 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ target-version = "py38"
exclude = [ "rasa_sdk/grpc_py", "eggs", ".git", ".pytest_cache", "build", "dist", ".DS_Store",]

[tool.poetry.dependencies]
python = ">=3.8,<3.13"
python = ">3.8,<3.13"
coloredlogs = ">=10,<16"
sanic = "^22.12"
typing-extensions = ">=4.1.1,<5.0.0"
Expand Down
7 changes: 0 additions & 7 deletions tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,6 @@ def test_cli_invalid_logging_configuration(
)


@pytest.mark.skipif(
sys.version_info.minor == 7, reason="no error is raised with python 3.7"
)
def test_cli_invalid_format_value_in_config(caplog: LogCaptureFixture) -> None:
root_dir = Path(__file__).resolve().parents[1]
logging_config_file = (
Expand All @@ -211,10 +208,6 @@ def test_cli_invalid_format_value_in_config(caplog: LogCaptureFixture) -> None:
)


@pytest.mark.skipif(
sys.version_info.minor != 8,
reason="no error is raised with python 3.9+",
)
def test_cli_non_existent_handler_id_in_config(caplog: LogCaptureFixture) -> None:
root_dir = Path(__file__).resolve().parents[1]
logging_config_file = (
Expand Down

0 comments on commit f75c644

Please sign in to comment.