Generalize BVP classes to handle either real or complex numbers (Done by P.Palacios) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend BVP modules to work either with real or complex numbers
Add alias to call BVP classes
…mpilation and linking
…mpilation and linking
…mpilation and linking
…mpilation and linking
…mpilation and linking
…mpilation and linking
…mpilation and linking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have continue the PR made some months ago to generalize the BVP classes. Now we have defined some alises for both real or complex. For example:
using BatchedBVPHandlerReal = BatchedBVPHandler_impl;
using BatchedBVPHandlerComplex = BatchedBVPHandler_impl<thrust::complex>;
We have modified the modules of DPStokes and Poisson to use this aliases. We have already run the test: misc/bvp and BDHI/DPStokes and they have passed succesfully.
Also the documentation has been updated.