Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The password is in clear when unlock the addon on firefox #23

Open
rgiordani71 opened this issue Dec 7, 2018 · 8 comments
Open

The password is in clear when unlock the addon on firefox #23

rgiordani71 opened this issue Dec 7, 2018 · 8 comments
Milestone

Comments

@rgiordani71
Copy link

Bug Report

Please fill out this information:

  • Browser version:60.3.0esr
  • Extension version:1.3.1
  • Operating system:macos mojave

Before the update the password to unlock the OTP registered was hidden with *, now the password is in clear when I enter it


What are the steps to reproduce the bug?


Open the browser console (Hamburger menu > Web Developer > Browser Console) and include anything that is logged when the bug occurs.
This step is not always necessary.


Any screenshots or videos of the bug would be helpful.

@Rayquaza01
Copy link
Owner

Hello, this is actually the inverse of the problem in #16. Essentially, on Linux, password fields inside of extension popups cause the popup to automatically close. This is a bug in Firefox. As a quick fix, I changed the password field to a normal text field to prevent the extension from breaking on Linux until I could figure out a better solution.

@Rayquaza01
Copy link
Owner

Hello, I've fixed this in v1.3.2. It should now hide the password again (except on linux, where it will still show the password).

@rgiordani71
Copy link
Author

rgiordani71 commented Dec 12, 2018 via email

@Mebus
Copy link

Mebus commented Mar 11, 2019

Hello, I've fixed this in v1.3.2. It should now hide the password again (except on linux, where it will still show the password).

On Linux it still show's the password. Why wasn't this fixed?

Mebus

@Rayquaza01
Copy link
Owner

@Mebus There was a bug in Firefox a while back that caused extensions with password inputs in their popups to close immediately on Linux (see #16). I added a workaround to make the extension actually usable. The bug in Firefox seems to be fixed now though, so the workaround will be removed in the next version, which I will hopefully finish soon.

@felsgaertner
Copy link

I have Firefox 87 on Linux Mint 20.1. With add-on version 1.3.2 it is still clear text password entry.

@roncro
Copy link

roncro commented May 6, 2021

I am using RHEL 8.3, firefox 78.10.0esr (64-bit). I also see the clear password, and also it seems to not generate the correct MFA code? (compared to a phone app, which does generate the correct code)

@mrx23dot
Copy link

No issue on Firefox 115 on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants