Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import isn't working #14

Open
FireW700 opened this issue Oct 28, 2018 · 2 comments
Open

Import isn't working #14

FireW700 opened this issue Oct 28, 2018 · 2 comments

Comments

@FireW700
Copy link

Bug Report

  • Browser version: Firefox 63.0 (64-bit) (for PC) and 62.0.3 (for Android)
  • Extension version: 1.2.4
  • Operating system: Windows 10 Version 1607 (Build 14393.2312), Android 6.0.0

Import previously saved notetaker.json file through "Browse..." button on the extension settings page doesn't change anything: "notetaker.json" appears next to "Browse..." button, but nothing has been imported.


Steps to reproduce the bug

Import previously saved notetaker.json file through "Browse..." button on the extension settings page.


Console logs

SyntaxError: JSON.parse: unterminated string at line 1 column 14670 of the JSON data options.js:139:19
importOptions/<
moz-extension://494a49a8-bc56-4bf3-b7af-e31ae82e5e54/options.js:139:19


For Author: I'm the same user who described this issue on addon commentary page (wich I deleted for now).

@Rayquaza01
Copy link
Owner

Hi, This is a weird question, but do you happen to have a # anywhere in your notes? It seems that # breaks the download button by making the URL end early. This causes the export to be incomplete, which then causes the import to break with an "unterminated string" error. I know how to fix it for the future, the export data just needs to be encoded before downloading.

@FireW700
Copy link
Author

That's great news! You're right, I have a couple of # in my notes, and exported json was incomplete. I've recreated notes from saved plain text and have successfully imorted it.
Thank you for investigating this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants