Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fails if underscore or space included in .json filename #34

Open
seascape opened this issue Feb 21, 2020 · 0 comments
Open

Import fails if underscore or space included in .json filename #34

seascape opened this issue Feb 21, 2020 · 0 comments

Comments

@seascape
Copy link

seascape commented Feb 21, 2020

Bug Report

Please fill out this information:

  • Browser version: Firefox 73.0.1
  • Extension version: 1.2.7
  • Operating system: Win10 x64

What happened?
A site changed its URL scheme so I had to export my notes and change a bunch of URLs via a regular expression. When I tried to re-import them Note Taker lost all notes and settings. The cause turned out to be introducing space and/or underscore characters in my fixed .json filename, so the workaround was thankfully trivial.

I would not be surprised if other ostensibly legal characters in the filename can cause this too.


How to reproduce:
Export notes. Add a space or underscore to the .json filename. Try to import the .json. Notes and settings should be lost.


When this occurs the browser console outputs the top two lines here:
Clip 000274 DR 75  New Issue · Rayquaza01_note-taker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant