Fixed config verification in IDEs with 'copy_target' feature

Razz4780 · Dec 5, 2023 · c80b254 · c80b254
1 parent 483f818
commit c80b254
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelog.d/+fix-verification.fixed.md b/changelog.d/+fix-verification.fixed.md
@@ -0,0 +1 @@
+Fixed config verification in IDE context when `copy_target` feature is used.
diff --git a/mirrord/config/src/config.rs b/mirrord/config/src/config.rs
@@ -58,7 +58,7 @@ pub type Result<T, E = ConfigError> = std::result::Result<T, E>;
 /// Struct used for storing context during building of configuration.
 #[derive(Default)]
 pub struct ConfigContext {
-    /// Are we in a IDE context?
+    /// Are we in an IDE context?
     ///
     /// Used by `Config::verify` to change some errors into warnings.
     pub ide: bool,

diff --git a/mirrord/config/src/lib.rs b/mirrord/config/src/lib.rs
@@ -442,7 +442,8 @@ impl LayerConfig {
                 ));
             }
 
-            if self.target.path.is_none() {
+            // Target may also be set later in the UI.
+            if self.target.path.is_none() && !context.ide {
                 return Err(ConfigError::Conflict(
                     "The copy target feature is not compatible with a targetless agent, \
                     please either disable this option or specify a target."
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed config verification in IDE context when `copy_target` feature is used.