Skip to content

Commit bec856b

Browse files
committed
remove an empty destructor to please g++-9 and CRAN / BDR
1 parent 3351beb commit bec856b

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

ChangeLog

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
2018-09-27 Dirk Eddelbuettel <[email protected]>
2+
3+
* inst/include/Rcpp/date_datetime/Date.h: Remove the empty destructor
4+
to make g++-9 (prerelease) happy [CRAN request]
5+
16
2018-09-26 Dirk Eddelbuettel <[email protected]>
27

38
* docker/ci/Dockerfile: Set env var RunAllRcppTests=yes

inst/NEWS.Rd

+15
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,21 @@
33
\newcommand{\ghpr}{\href{https://github.com/RcppCore/Rcpp/pull/#1}{##1}}
44
\newcommand{\ghit}{\href{https://github.com/RcppCore/Rcpp/issues/#1}{##1}}
55

6+
\section{Changes in Rcpp version 0.12.20 (2018-11-xx)}{
7+
\itemize{
8+
\item Changes in Rcpp API:
9+
\itemize{
10+
\item The empty destructor for the \code{Date} class was removed
11+
to please g++-9 (prerelease) and \code{-Wdeprecated-copy} (Dirk).
12+
}
13+
\item Changes in Rcpp Deployment:
14+
\itemize{
15+
\item The Dockerfile for Continuous Integration sets the required
16+
test flag (for release versions) inside the container (Dirk).
17+
}
18+
}
19+
}
20+
621
\section{Changes in Rcpp version 0.12.19 (2018-09-20)}{
722
\itemize{
823
\item Changes in Rcpp API:

inst/include/Rcpp/date_datetime/Date.h

-2
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ namespace Rcpp {
6767
m_d = tmp/(24*60*60);
6868
}
6969

70-
~Date() {};
71-
7270
double getDate(void) const {
7371
return m_d;
7472
}

0 commit comments

Comments
 (0)