Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R 3.6.x Update for Sample Extension #250

Open
coatless opened this issue Mar 10, 2019 · 1 comment
Open

R 3.6.x Update for Sample Extension #250

coatless opened this issue Mar 10, 2019 · 1 comment

Comments

@coatless
Copy link
Contributor

Glancing over the RcppArmadillo code, the Alt RNG setup directly uses R's RNG for uniform (e.g. Rf_runif(). However, the extension code in inst/RcppArmadilloExtension/sample.h does not.

So, likely this will need a patch that mirrors what is available in Base R. c.f. Implementation changes.

This will likely be needed with Rcpp's local variant as well designed by @nathan-russell.

@coatless
Copy link
Contributor Author

Per a quick slack discussion, we'll likely want to rewrite portions of RcppArmadilloExtensions/sample.h to reuse parts of the Sugar functions in Rcpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants