-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Input File Format from .py
to .yaml
#2634
Comments
This is a great initiative and I'm on board with this. A couple of initial thoughts:
|
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
Should probably reformat this as a RIP |
Motivation or Problem
Right now to run RMG, users write a functional Python script which is then actually executed (using
exec
) by RMG to load the requested reactors, species etc. into memory. The problems with this are:exec
is a security riskexec
is difficult to debugexec
requires passing the global and local namespace to the executed file, which is slowDesired Solution
I mentioned in #2633 that the Green group has been planning to switch the input file format to YAML, and with the opening of #2633 it seems like a good time to announce this formally.
In line with
cantera
,RMS
, and so many other modern tools, users will specify their simulation setup in ayaml
format like:which will then be loaded by RMG.
Potential Alternatives
The easy thing to do would be to just not do this, but for the outlined reasons this is a bad idea.
etc.
environment.yml
Unblocking Python 3.11 - rdkit to conda-forge channel, remove chemprop for now #2553 we can now begin to move to Python 3.11+ (see Python 3.7 End-of-Life and Upgrading to Python 3.11 #2445 and https://github.com/orgs/ReactionMechanismGenerator/projects/11/views/1?layout=board) which will make doing this easier, so we will implement this new loader based on that work..py
files to the new.yaml
format? I suspect this would be more difficult than it seems, and it is not a significant burden to ask people to rewrite their input files in the new simpler format (IMO, welcome thoughts here).The text was updated successfully, but these errors were encountered: