-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitization error for Carbon Monoxide? #489
Comments
Not sure how we ought best to represent CO, but a molecule search for "carbon monoxide" returns formaldehyde, and one for |
In Wikipedia (for what it's worth) carbon monoxide's SMILES is See Issues: RMP-Py #184, ReactionMechanismGenerator/RMG-database#31 @connie reccomended to represent CO as
Another problem (which brought up this issue for me in the first place) is that currently only radicals can react to abstract a proton in the H_Abstraction kinetic family ( |
Hi, I am using 796adab version of RMG-Py. I am also getting both [C-]#[O+] and [C]=O in the mechanism. The mechanism generated contains CH4, C2H6 and C3H8 chemistry. |
I believe the I do believe that |
Just ran 4 simulations of: this structure of CO seems to react in RMG only via the
I did not get any of the following reactions (looked in chem_edge_annotated.inp as well):
These are probably important to many RMG works, and should be added to the |
Sounds like this needs some serious attention. |
In second thought, maybe
While we need to form a unique triple bond (
I couldn't see any other fit from our reaction families. |
Perhaps we should open a Strengthening the Wikipedia comment from above, the following paper says that |
I think CO representation has been fixed, and the CO_disprop family has also been added already. |
My understanding is that we represent carbon monoxide as the triple-bonded structure with charged atoms, each atom bearing 1 lone pair.
When I run this Molecule through RDKit's
Chem.Sanitize
, it complains the valency is not correct.RMG-Py, by default, runs RDKit's sanitize functionality for compounds that do not contain nitrogen atoms.
I wonder how the error of CO should be treated. The options I see:
I could not find prior raised issues on this topic, apart from #367, in which the representation of carbon monoxide in the
solvation.transformLonePairs
function of RMG-Py was changed into the biradical to avoid the same SanitizationError. bslakman@aa15c5cThe text was updated successfully, but these errors were encountered: