Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing in Julia 1.10 #11

Closed
bvdmitri opened this issue Jan 12, 2024 · 5 comments · Fixed by #10
Closed

Tests are failing in Julia 1.10 #11

bvdmitri opened this issue Jan 12, 2024 · 5 comments · Fixed by #10
Assignees

Comments

@bvdmitri
Copy link
Member

See for example this

@bvdmitri
Copy link
Member Author

This could have potentially caused the issue with the continuous transition node in ReactiveMP here ReactiveBayes/ReactiveMP.jl#372

@bartvanerp
Copy link
Member

bartvanerp commented Jan 15, 2024

Corresponding test seems to check inversion of a very bad matrix, so I am not entirely surprised about just exceeding the tolerances. Robustness in the test could be improved anyways. Instead of computing inv(A)*B you should always call A\B.

@bartvanerp
Copy link
Member

Might also be related to PostiveFactorizations that we use as a fallback. Not sure whether it uses that one in the test case, but will check later.

@bartvanerp
Copy link
Member

bartvanerp commented Jan 15, 2024

It has to do with our own fastcholesky implementation, but I can't reproduce this on my Mac, so it seems to be system-dependent. @bvdmitri I propose to just increase tolerances. Calling A \ B will just pass, so the method still works anyway.

@bvdmitri
Copy link
Member Author

Couldn't reproduce it on my mac either. I've adjusted the tests a bit

@bartvanerp bartvanerp linked a pull request Jan 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants