Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importance sampling for GammaMixture support. #84

Open
albertpod opened this issue Feb 8, 2022 · 4 comments
Open

Importance sampling for GammaMixture support. #84

albertpod opened this issue Feb 8, 2022 · 4 comments
Assignees
@ismailsenoz

Comments

@albertpod
Copy link
Member

We have (tw @bvdmitri ) spotted an issue with running an important sampling strategy around the GammaMixture node.
We proposed this strategy n this paper.

The API for the form constraint has changed i.e.
as = randomvar(nmixtures, prod_constraint = ProdGeneric(), form_constraint = SampleListFormConstraint(rng, 1000, LeftProposal()))
compared to
as = randomvar(nmixtures, prod_strategy = as_prod_strategy, constraint = as_constraint)
@bvdmitri
Copy link
Member

bvdmitri commented Sep 30, 2022 •
edited by albertpod
Loading

  • Sampling from GammaShapeRate is broken

@albertpod albertpod mentioned this issue Sep 30, 2022
Closed
@albertpod
Copy link
Member Author

PR #222

@albertpod albertpod moved this to 📝 In progress in RxInfer Feb 21, 2023
@albertpod
Copy link
Member Author

This issue is related to #27; I will sync the end date for this issue accordingly.

@albertpod albertpod removed this from RxInfer Apr 3, 2023
@albertpod
Copy link
Member Author

Just a self reminder that this needs to be checked. I don't think that #27 fixed this particular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailsenoz ismailsenoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bvdmitri @albertpod @ismailsenoz