Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Image Links empty #7345

Closed
Gurran opened this issue Sep 22, 2023 · 3 comments
Closed

Documentation Image Links empty #7345

Gurran opened this issue Sep 22, 2023 · 3 comments

Comments

@Gurran
Copy link

Gurran commented Sep 22, 2023

Describe the bug

When rendering the description of a method in rxjs the redered markdown does not show any image.

Example in WebStorm:
Screenshot from 2023-09-22 11-29-47

The link to the image is empty in the source file is empty.

https://github.com/ReactiveX/rxjs/blob/0bd47eab10dec89f245b888f1f26e03cb36d2a78/packages/rxjs/src/internal/operators/take.ts#L12C1-L12C17

Expected behavior

I would expect the image tag to not be empty and instead point to the same URL as the docs site uses for images.
I this case https://rxjs.dev/assets/images/marble-diagrams/take.png

Reproduction code

No response

Reproduction URL

No response

Version

master

Environment

No response

Additional context

No response

@jakovljevic-mladen
Copy link
Member

We have an open discussion about this issue, please take a look here.

I'm gonna close this because GitHub issues should be used only for the core library bugs. Thanks for reporting.

@Gurran
Copy link
Author

Gurran commented Sep 22, 2023 via email

@jakovljevic-mladen
Copy link
Member

It is active even though we don't currently work on the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants