[feat] 게시글 댓글 등록, 삭제 #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinnjuu
requested changes
Nov 1, 2022
| @DeleteMapping(value="/posts/{id}/comment") | ||
| public ResponseEntity deleteComment(@PathVariable("id") Long id){ | ||
| commentService.delete(id); | ||
| return ResponseEntity.ok(id); |
There was a problem hiding this comment.
삭제되었을때 상태코드 같이 리턴해주시면 좋을 것 같습니다!
| } | ||
|
|
||
| //댓글 삭제 | ||
| @DeleteMapping(value="/posts/{id}/comment") |
There was a problem hiding this comment.
url 의미가 조금 맞지 않아 수정이 필요해 보입니다. 컨트롤러에 맵핑된 id (파라미터로 받은 id) 는 게시글 id 인데, 실제 서비스에서 삭제하는 id 는 댓글 id 입니다.
컨트롤러 url 을 /posts/{post-id}/comments/{comment-id} 등으로 수정하면 좋을 것 같습니다!
| @Transactional | ||
| public void delete(Long id) { | ||
| Comment comment = commentRepository.findById(id).orElseThrow(() -> | ||
| new IllegalArgumentException("존재하지 않는 댓글입니다. id=" + id)); |
There was a problem hiding this comment.
에러가 로그상에만 떨어지고 있는데 리턴값으로도 에러메세지나 상태코드를 넘겨주면 프론트에서 처리하기 좋을 것 같습니다.
There was a problem hiding this comment.
controller와 service 수정하였습니다.
jinnjuu
reviewed
Nov 30, 2022
| commentService.delete(id); | ||
| return ResponseEntity.ok(id); | ||
| @DeleteMapping(value="/posts/{post-id}/comment/{comment-id}") | ||
| public ResultResponse deleteComment(@PathVariable("post-id")Long PostId,@PathVariable("comment-id") Long CommentId){ |
There was a problem hiding this comment.
변수명 첫글자는 소문자로 작성하면 좋을 듯 합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
post /posts/{id}/comment
댓글 등록 - 성공
댓글 등록 - 에러 : 100글자 이상 등록한 경우
delete /posts/{id}/comment
댓글 삭제